fix(RunOnce): change to form submission instead of onKeyDown and onClick#8460
Merged
crazywoola merged 1 commit intolanggenius:mainfrom Sep 15, 2024
Merged
Conversation
12 tasks
crazywoola
approved these changes
Sep 15, 2024
LLmoskk
pushed a commit
to LLmoskk/dify
that referenced
this pull request
Sep 16, 2024
laipz8200
pushed a commit
that referenced
this pull request
Sep 18, 2024
cuiks
pushed a commit
to cuiks/dify
that referenced
this pull request
Sep 26, 2024
lau-td
pushed a commit
to heydevs-io/dify
that referenced
this pull request
Oct 23, 2024
idonotknow
pushed a commit
to AceDataCloud/Dify
that referenced
this pull request
Nov 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsDescription
Solves the problem of the IME being sent during composing. There are several solutions, but the use of form submit events was considered the most appropriate.
CleanShot.2024-09-15.at.13.09.12.mp4
CleanShot.2024-09-15.at.13.07.37.mp4
reproducable workflow DSL
Another Solution
The first possible solution is to use
KeyboardEvent.isComposing, but this does not work as expected in Safari.ref: Please do not implement
Enter key to Submitbehaviors by directly hooking into the raw keypress event.I initially considered implementing it: #8459
Current Solution
I have implemented form submission using the onSubmit event of the form element. (This behavior is commonly referred to as implicit submission.)
This approach maintains the existing functionality of submitting the form via the submit button or by pressing enter in an input element, while simplifying the code and avoiding issues in browsers like Safari.
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration