Skip to content

fix: same chunk insert deadlock#12502

Merged
JohnJyong merged 2 commits intolanggenius:mainfrom
huangzhuo1949:fix-same-chunk-bug
Jan 9, 2025
Merged

fix: same chunk insert deadlock#12502
JohnJyong merged 2 commits intolanggenius:mainfrom
huangzhuo1949:fix-same-chunk-bug

Conversation

@huangzhuo1949
Copy link
Contributor

@huangzhuo1949 huangzhuo1949 commented Jan 8, 2025

Summary

Distribute documents into multiple groups based on the hash values of page_content.
This is done to prevent multiple threads from processing the same document, thereby avoiding potential database insertion deadlocks.

fix #12481

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 8, 2025
@dosubot dosubot bot added the 🐞 bug Something isn't working label Jan 8, 2025
@crazywoola
Copy link
Member

Please fix the tests.

@huangzhuo1949
Copy link
Contributor Author

Please fix the tests.

done~

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 9, 2025
@JohnJyong JohnJyong merged commit e84bf35 into langgenius:main Jan 9, 2025
11 checks passed
alexcodelf pushed a commit to alexcodelf/dify that referenced this pull request Jan 21, 2025
Co-authored-by: huangzhuo <huangzhuo1@xiaomi.com>
jsincorporated pushed a commit to jsincorporated/asaAi that referenced this pull request Jul 8, 2025
Co-authored-by: huangzhuo <huangzhuo1@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

psycopg2.errors.DeadlockDetected: deadlock detected

3 participants