Skip to content

fix: non utf8 code decode close #10691#10698

Merged
laipz8200 merged 2 commits intolanggenius:mainfrom
yihong0618:hy/fix_utf8_decode
Nov 14, 2024
Merged

fix: non utf8 code decode close #10691#10698
laipz8200 merged 2 commits intolanggenius:mainfrom
yihong0618:hy/fix_utf8_decode

Conversation

@yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Nov 14, 2024 •
edited
Loading

Summary

close #10691 by ignore non utf8 char

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@yihong0618
fix: non utf8 code decode close langgenius#10691
3377cf7 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 14, 2024
@crazywoola crazywoola requested a review from laipz8200 November 14, 2024 09:12
@yihong0618
fix: lint with ruff
3de4167 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
laipz8200
laipz8200 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and nice testing! 😊

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 14, 2024
@laipz8200 laipz8200 merged commit 7229646 into langgenius:main Nov 14, 2024
@yihong0618 yihong0618 deleted the hy/fix_utf8_decode branch November 14, 2024 09:53
@yihong0618 yihong0618 mentioned this pull request Nov 14, 2024
Merged
5 tasks
AlwaysBluer pushed a commit to AlwaysBluer/dify that referenced this pull request Nov 14, 2024
@yihong0618 @AlwaysBluer
fix: non utf8 code decode close langgenius#10691 (langgenius#10698)
b7edddd 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@laipz8200 laipz8200 mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laipz8200 laipz8200 laipz8200 approved these changes

Assignees

No one assigned

Labels

🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

2 participants

@yihong0618 @laipz8200