-
Notifications
You must be signed in to change notification settings - Fork 523
chore: update DataFusion, Arrow, Object Store #4598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update DataFusion, Arrow, Object Store #4598
Conversation
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
|
I am trying to upgrade and received the same error in #4593. I will wait for this then 😆 |
|
Digging into this for this and also #4593 the problem I'm seeing in I don't think we want to bump arrow to 56 with datafusion at 49 because datafusion is at arrow 55 and that would have duplicate dependencies. I added a TODO in the code I pushed to work around this error. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4598 +/- ##
==========================================
- Coverage 80.58% 80.56% -0.02%
==========================================
Files 317 317
Lines 119272 119281 +9
Branches 119272 119281 +9
==========================================
- Hits 96111 96103 -8
- Misses 19713 19727 +14
- Partials 3448 3451 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@westonpace I'm not familiar with the CI failure I'm seeing here - it looks like something related to file system errors on windows. Is that something you've seen in this repo? I'm also not wild about the fix I put in for the test I describe in the comments above, but I believe it can be removed in the next version, DF50 which should bring Arrow 56 |
9f49ec2 to
9c7d469
Compare
9c7d469 to
8f8afdb
Compare
|
It looks like the CI failure I was getting earlier was resolved after rebase. I think this is ready to go. |
jackye1995
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
This PR is to update the following dependencies:
The rest of the changes are just due to updates upstream, but none are breaking.