refactor!: deprecate TFRecord support #4593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
reviewed
Aug 28, 2025
wjones127
reviewed
Aug 28, 2025
Contributor
wjones127
left a comment
There was a problem hiding this comment.
I think the things we want to delete are the tfrecord stuff, which is the only part we have Rust bindings for.
The other tensorflow stuff in Python I think we can keep.
d8f16fd to
5b193bf
Compare
a53730a to
770d764
Compare
6a0cd3f to
8f7217e
Compare
Contributor
|
I added a work around for the unit test failure in #4598 |
Contributor
|
My guess is that for this PR if you reverted your cargo lock's arrow and datafusion it would pass. |
8f7217e to
4447710
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4593 +/- ##
==========================================
+ Coverage 80.58% 80.89% +0.30%
==========================================
Files 317 316 -1
Lines 119671 119054 -617
Branches 119671 119054 -617
==========================================
- Hits 96439 96308 -131
+ Misses 19773 19294 -479
+ Partials 3459 3452 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3d33fbb to
3c52c49
Compare
3c52c49 to
312f50f
Compare
Xuanwo
approved these changes
Nov 17, 2025
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes TFRecord support from Lance while maintaining TensorFlow tf.data integration. Closes #4586