Fix field name checks for aliases in header constructors#225
Merged
Slamdunk merged 10 commits intolaminas:2.21.xfrom Jan 6, 2023
Merged
Fix field name checks for aliases in header constructors#225Slamdunk merged 10 commits intolaminas:2.21.xfrom
Slamdunk merged 10 commits intolaminas:2.21.xfrom
Conversation
Signed-off-by: Renovate Bot <bot@renovateapp.com>
Signed-off-by: Renovate Bot <bot@renovateapp.com>
Signed-off-by: Renovate Bot <bot@renovateapp.com>
Signed-off-by: Renovate Bot <bot@renovateapp.com>
Signed-off-by: Renovate Bot <bot@renovateapp.com>
Ocramius
requested changes
Jan 3, 2023
Member
Ocramius
left a comment
There was a problem hiding this comment.
This kind of change requires test additions.
…s for the sake of compatibility with HeaderLocator Signed-off-by: George Shestayev <george@uniques.ca>
7c1f98d to
efe9b82
Compare
Signed-off-by: George Shestayev <george@uniques.ca>
9e5fdee to
527b58e
Compare
Signed-off-by: George Shestayev <georges@uniques.ca>
…standards Signed-off-by: George Shestayev <georges@uniques.ca>
Signed-off-by: George Shestayev <georges@uniques.ca>
Slamdunk
approved these changes
Jan 6, 2023
Contributor
|
Thank you @georgique |
artemii-karkusha
pushed a commit
to artemii-karkusha/laminas-mail
that referenced
this pull request
May 24, 2023
Fix field name checks for aliases in header constructors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Header constructors are improved to allow less correct header names for the sake of compatibility with HeaderLocator.
The following header names are now accepted:
This list is now compatible with https://github.com/laminas/laminas-mail/blob/2.22.x/src/Header/HeaderLocator.php.
Are you fixing a bug or providing a failing unit test to demonstrate a bug?
Fixing a bug
How do you reproduce it?
Receive a message via POP3 with one of the aforementioned headers present.
What did you expect to happen?
Header to be accepted and parsed, and message object created.
What actually happened?
Exception thrown. Even though HeaderLocator is fine with such a header name, header's constru
Are you adding documentation?
No
Are you providing a QA improvement (additional tests, CS fixes, etc.) that
does not change behavior?
No
Are you fixing a BC Break?
No
Are you adding something the library currently does not support?
No
Are you refactoring code?
No