Skip to content

Add support for PHP 8.2#214

Merged
Ocramius merged 5 commits intolaminas:2.19.xfrom
gsteel:PHP-8.2
Oct 14, 2022
Merged

Add support for PHP 8.2#214
Ocramius merged 5 commits intolaminas:2.19.xfrom
gsteel:PHP-8.2

Conversation

@gsteel
Copy link
Copy Markdown
Member

@gsteel gsteel commented Oct 14, 2022

Q A
New Feature yes

@gsteel gsteel added this to the 2.19.0 milestone Oct 14, 2022
Signed-off-by: George Steel <george@net-glue.co.uk>
…stringify non-existent classes

Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
@Ocramius
Copy link
Copy Markdown
Member

idn_to_ascii missing in the CI environment? 🤔

@gsteel
Copy link
Copy Markdown
Member Author

gsteel commented Oct 14, 2022

I think it's weirdness with symfony polyfills and the intl extension - can't reproduce the issue locally

@gsteel gsteel force-pushed the PHP-8.2 branch 2 times, most recently from 369c81d to 2eaadc5 Compare October 14, 2022 12:48
Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel
Copy link
Copy Markdown
Member Author

gsteel commented Oct 14, 2022

So CI removes the intl extension and the symfony polyfills don't have any types - hopefully the assertions and var annotations will cover it?

Copy link
Copy Markdown
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution to the type issue looks good, thanks @gsteel!

@Ocramius Ocramius self-assigned this Oct 14, 2022
@Ocramius Ocramius merged commit edf3832 into laminas:2.19.x Oct 14, 2022
@gsteel gsteel deleted the PHP-8.2 branch October 14, 2022 13:12
artemii-karkusha pushed a commit to artemii-karkusha/laminas-mail that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants