Fold a string with the correct length#174
Merged
Slamdunk merged 3 commits intolaminas:2.18.xfrom Sep 20, 2022
danielabyan:feature/fold-header-properly
Merged
Fold a string with the correct length#174Slamdunk merged 3 commits intolaminas:2.18.xfrom danielabyan:feature/fold-header-properly
Slamdunk merged 3 commits intolaminas:2.18.xfrom
danielabyan:feature/fold-header-properly
Conversation
glensc
reviewed
Oct 21, 2021
According to the RFC 2822 specification (clause 2.1.1), the header length should be no more than 78 characters. "Each line of characters MUST be no more than 998 characters, and SHOULD be no more than 78 characters, excluding the CRLF." According to the specification, the length of the ENTIRE LINE should not exceed 78 characters. Currently, the `laminas-mail` library only counts the length of a value of the header. This commit has fixed this issue. Signed-off-by: danielabyan <danielabyan@gmail.com>
In order for the change to take effect, it is necessary to update the `laminas/laminas-mime` library. Signed-off-by: danielabyan <danielabyan@gmail.com>
Signed-off-by: danielabyan <danielabyan@gmail.com>
Slamdunk
approved these changes
Sep 20, 2022
artemii-karkusha
pushed a commit
to artemii-karkusha/laminas-mail
that referenced
this pull request
May 24, 2023
…roperly Fold a string with the correct length
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to the RFC 2822 specification (clause 2.1.1), the header length should be no more than 78 characters.
According to the specification, the length of the ENTIRE LINE should not exceed 78 characters. Currently, the
laminas-maillibrary only counts the length of a value of the header.Reproducing the problem
This code will return the following result.
As you can see from the example, the header is longer than 78 characters.
New code behavior
This commit has fixed this issue. In this pool request, the code above will return the following result.
Now, the title does not exceed 78 characters.
Note
Waiting for pooling request on laminas-mime