phpunit9 and php8 by delboy1978uk · Pull Request #127 · laminas/laminas-mail

delboy1978uk · 2021-01-13T22:13:24Z

This cant be merged until the following are PHP 8 ready, as I have changed the repos/branches in the composer.json in order that we could work on this:
laminas/laminas-crypt#11
laminas/laminas-mime#14
laminas/laminas-math#5

Q	A
Documentation	/no
Bugfix	/no
BC Break	/no
New Feature	yes/
RFC	/no
QA	/no

Description

get mail working on php8 and phpunit9

delboy1978uk · 2021-01-13T22:29:57Z

This cant be merged until the following are PHP 8 ready, as I have changed the repos/branches in the composer.json in order that we could work on this:
laminas/laminas-crypt#11
laminas/laminas-mime#14
laminas/laminas-math#5

glensc · 2021-01-14T09:34:03Z

@delboy1978uk, my 0.2c:

you should rebase, not merge upstream changes. it's difficult to review if your PR commits 59 commits that are not even yours. git push -f to update branch after rebase (don't create another PR!)
you can mark PR as "draft", if it's not ready for merge (waiting for dependencies)
you can probably put the waiting for merge note in PR body, more visible than single comment at bottom of the PR after tons of changes (most of the noise is due merge commits included in PR).

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

- Update Folder\Mbox construct param types - Update Storage\Imap construct param types - Update Storage\Maildir construct param types - Update Storage\Mbox construct param types - Update Storage\Pop3 construct param types Signed-off-by: Elan Ruusamäe <glen@pld-linux.org> Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

Signed-off-by: Elan Ruusamäe <glen@pld-linux.org> Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

Ocramius · 2021-01-17T17:10:38Z

+    "repositories": [
+        {
+            "type": "git",
+            "url": "https://github.com/delboy1978uk/laminas-crypt.git"


To be dropped before merge

Ocramius · 2021-01-17T17:10:41Z

+        },
+        {
+            "type": "git",
+            "url": "https://github.com/bfoosness/laminas-mime"


To be dropped before merge

Ocramius · 2021-01-17T17:10:44Z

+        },
+        {
+            "type": "git",
+            "url": "https://github.com/bfoosness/laminas-math.git"


To be dropped before merge

delboy1978uk · 2021-01-20T15:16:00Z

Hi @Ocramius , I'm a little confused as to why the build is failing on that last commit e4f70ed? Also it passes on my own travis page? https://travis-ci.com/github/delboy1978uk/laminas-mail/builds/213443818
Do I need to keep rebasing it periodically?

Ocramius · 2021-01-20T15:20:56Z

@delboy1978uk don't really understand the failure either:

1) Error

The data provider specified for LaminasTest\Mail\Header\ContentDispositionTest::testParameterWrapping is invalid.

PHPUnit\Framework\InvalidDataProviderException: The key "With two ordered items" has already been defined in the data provider "parameterWrappingProvider".

This seems to be related with a phpunit upgrade, perhaps.

The warning on opening a temporary file is more complex, but unsure if related to travis-ci infrastructure.

glensc · 2021-01-20T16:08:53Z

@Ocramius For #127 (comment)

I already replied via #117 (comment), it's fixed with this PR:

Tests: Resolve duplicate data provider key #129

why there are two PR's doing the same?

delboy1978uk · 2021-01-21T15:53:11Z

@glensc that might have been my fault, I see the other PR was there first now. I was loading one of my own packages into PHP8 and I noticed it still wasn't ready, so without a thought I just downloaded to help where I can. What's the vibe to get your data provider key PR into my branch, do I cherry pick it or just wait for the merges to happen?

glensc · 2021-01-21T17:53:52Z

I pinged @Ocramius to merge #129 (comment), he's been active recently in this project. So I'd rebase once that','s merged, or if want to fix CI, cherry-pick and convert PR to Draft to prevent premature merge.

This project does not have a CONTRIBUTING.md guide, so I'm don't what's the procedures. If this ould be my project, I would ask first to rebase and squash some commits, maybe even extract changes to separate PR to merge ahead. usually, I've pointed people to these guides, how to make good commits and commit messages. 39 commits here seems way too much.

froschdesign · 2021-01-21T18:29:11Z

@glensc

This project does not have a CONTRIBUTING.md guide…

This project uses the GitHub functionality for this and therefore, under each text field you will find:

Remember, contributions to this repository should follow its contributing guidelines and code of conduct.

Ocramius · 2021-01-26T13:36:39Z

These changes are now included through #117, thanks @delboy1978uk!

delboy1978uk force-pushed the 2.13.x branch from 3f34494 to 5e7aaf5 Compare January 13, 2021 22:18

delboy1978uk and others added 27 commits January 15, 2021 16:54

update to phpunit9 on php8

30ffe73

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

drop support for php < 7.3, add 8.0 to travis.yml

c8190c1

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

Fixes to prevent phpcs line length violation

6f9df17

Signed-off-by: Elan Ruusamäe <glen@pld-linux.org> Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

fix whitespace in yaml

931bfda

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

var dump to see on travis

b9d6c6b

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

cs line length check

e0ff0e7

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

cs fixes

a8c96ed

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

remove var dump

f3cba3f

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

debug

416ca89

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

check for warnings

af59f3b

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

check string can explode

3d9bb6d

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

check string can explode

be4a1dd

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

check string explode

33d558f

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

debug 8 branch

f291328

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

vardump

f43f3dc

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

more debug

ea3c0dd

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

debugging travis job

ab31230

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

attempt fix

3cf0bdc

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

fix another list() call

a6fedb5

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

try catch folder exception

b179e8c

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

add -vvv to phpunit

d5b64b2

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

only change folder if it splits

9e65871

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

revert to list again

335860d

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

fix list call()

84a88b4

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

cs fix

799eaa3

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

remove -vvv from composer json

778f030

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

delboy1978uk added 11 commits January 15, 2021 17:08

type error

9f1b855

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

add runtime exception

36f7545

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

cs check

acafe43

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

try catch fclose

f600b15

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

check for type error php 8

bd5621e

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

add asserttion testNotReadableFolder to fix risky test

8161331

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

fix risky test

56ccc84

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

cs fix

7f6425d

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

resource check

ef1ddc7

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

put back old exceptions

d4effd4

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

remove debug var

8bf090a

Signed-off-by: Derek Stephen McLean <delboy1978uk@gmail.com>

delboy1978uk force-pushed the 2.13.x branch from 5e7aaf5 to 8bf090a Compare January 15, 2021 16:09

Ocramius requested changes Jan 17, 2021

View reviewed changes

Ocramius added the Enhancement label Jan 17, 2021

Ocramius added this to the 2.13.0 milestone Jan 17, 2021

Ocramius mentioned this pull request Jan 17, 2021

[2.14]: QA: Add specific type hints for $params #126

Merged

minimum 7.3 in composer.json

e4f70ed

glensc mentioned this pull request Jan 20, 2021

Tests: Resolve duplicate data provider key #129

Merged

Ocramius added the Duplicate This issue or pull request already exists label Jan 26, 2021

Ocramius self-assigned this Jan 26, 2021

Ocramius closed this Jan 26, 2021

Uh oh!

Conversation

delboy1978uk commented Jan 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

delboy1978uk commented Jan 13, 2021

Uh oh!

glensc commented Jan 14, 2021

Uh oh!

Ocramius Jan 17, 2021

Choose a reason for hiding this comment

Uh oh!

Ocramius Jan 17, 2021

Choose a reason for hiding this comment

Uh oh!

Ocramius Jan 17, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

delboy1978uk commented Jan 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ocramius commented Jan 20, 2021

Uh oh!

glensc commented Jan 20, 2021

Uh oh!

delboy1978uk commented Jan 21, 2021

Uh oh!

glensc commented Jan 21, 2021

Uh oh!

froschdesign commented Jan 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Ocramius commented Jan 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

delboy1978uk commented Jan 13, 2021 •

edited

Loading

delboy1978uk commented Jan 20, 2021 •

edited

Loading

froschdesign commented Jan 21, 2021 •

edited

Loading