This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Add PHP 8.0 support#5
Merged
Ocramius merged 2 commits intolaminas:3.3.xfrom Jan 21, 2021
bfoosness:php-8.0
Merged
Conversation
Signed-off-by: Brent Foosness <bfoosness@users.noreply.github.com>
Signed-off-by: Brent Foosness <bfoosness@users.noreply.github.com>
bfoosness
commented
Dec 11, 2020
snapshotpl
approved these changes
Dec 11, 2020
6 tasks
This was referenced Jan 12, 2021
glensc
reviewed
Jan 18, 2021
Ocramius
approved these changes
Jan 21, 2021
Member
Ocramius
left a comment
There was a problem hiding this comment.
LGTM 👍
I'll prepare release automation too, since right now we're targeting master.
Member
|
Thanks @bfoosness! |
Contributor
Author
@Ocramius, could I bother you to set up the same for laminas/laminas-json#10? I think that PR may be ready to go, but release automation is the blocker. Thank you in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #4