feat(l1, l2): apply fork choice even when PayloadAttributes are invalid#870
Merged
Merged
Conversation
…beacon block root test.
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
…alid (lambdaclass#870) Changes - Make payload attributes a result type in the request. This allows us to represent errors in the request that will be handled. - `handle` now takes into account the possibility of payload attributes being an error, but only cares about it after fork choice has been applied. - The L2 client has been updated to take this into account and uses `Ok(Some(attributes))` now. To the client user it will not notice the changes as the parameters of the function do not change. - Re-add the missing beacon block root hive test, now correctly working. Closes lambdaclass#853
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
handlenow takes into account the possibility of payload attributes being an error, but only cares about it after fork choice has been applied.Ok(Some(attributes))now. To the client user it will not notice the changes as the parameters of the function do not change.Closes #853