🤖 Kimi Code Review

This PR contains a version bump (11.0.0 → 12.0.0) and a critical bugfix in the LEVM account backup/restore logic. The VM changes fix a consensus-critical issue where account backups were capturing post-modification state rather than pre-modification state.

Critical Fix Review (LEVM)

crates/vm/levm/src/db/gen_db.rs

Lines 537-542: The reordering to backup before get_account_mut is correct. get_account_mut likely calls mark_modified() which flips exists to true for lazy account creation. Capturing the backup after this mutation would cause revert operations to restore incorrect state.

Lines 551-553, 582-584: The zero-amount early returns are safe optimizations for balance operations. However, verify this doesn't skip required account "touching" for state trie clearance (EIP-158/161). If increase_account_balance(0) is called on a non-existent account, skipping the operation means it remains non-existent, which is likely correct since no actual state change occurs.

crates/vm/levm/src/hooks/default_hook.rs

Lines 365-370: Consistent application of the backup fix for self-destruct operations. Good.

crates/vm/levm/src/utils.rs

Line 85: Adding exists restoration is necessary to complete the fix. Without this, reverting a transaction that caused account creation would leave exists = true while other fields revert, causing state corruption.

Suggestions

1. Documentation: Add a comment in increase_account_balance and decrease_account_balance explaining why zero-amount operations are no-ops (e.g., "Ethereum treats zero-value transfers as no-ops for balance state").

2. Consider atomicity: The pattern get_account → backup → get_account_mut is correct but relies on the fact that no other reference can mutate the DB between these calls. Ensure this is single-threaded or properly synchronized.

3. Testing: Ensure there are tests covering:

   • Reverting account creation (touching a non-existent account then reverting)
   • Self-destruct revert scenarios
   • Zero-value balance operations not creating accounts

Verdict

The VM changes are a correct and necessary bugfix. The version bump is mechanical and consistent across the workspace. Approve pending confirmation that zero-value optimization doesn't violate any EIP-161 state clearing rules.

Automated review by Kimi (Moonshot AI) · kimi-k2.5 · custom prompt

🤖 Claude Code Review

Here is my review of PR #6602:

PR #6602 — chore(l1,l2): bump version to 12.0.0

Overview

This is a release preparation PR that bumps the workspace version from 11.0.0 to 12.0.0. It covers:

• Root Cargo.toml workspace version bump
• All guest-program Cargo.toml files (sp1, risc0, openvm, zisk) and crates/l2/tee/quote-gen/Cargo.toml
• All associated Cargo.lock files refreshed via make update-cargo-lock
• docs/CLI.md default string updated for --builder.extra-data
• Two levm bug fixes cherry-picked into the release branch (described in the PR body, commits d71b53d68 and 36da5e14e)

Version Bump Consistency

All workspace crates appear to be bumped uniformly from 11.0.0 to 12.0.0. Coverage is thorough across:

• Main workspace (Cargo.lock, Cargo.toml)
• crates/guest-program/bin/{openvm,risc0,sp1,zisk}/Cargo.{toml,lock}
• crates/l2/tee/quote-gen/Cargo.{toml,lock}
• crates/vm/levm/bench/revm_comparison/Cargo.lock
• tooling/Cargo.lock

No crate appears to have been accidentally left at 11.0.0.

Observations

Stale 1.0.0 entries in tooling/Cargo.lock

In tooling/Cargo.lock, the following pattern appears:

  "ethrex-common 1.0.0",
- "ethrex-common 11.0.0",
+ "ethrex-common 12.0.0",
  "ethrex-storage 1.0.0",
- "ethrex-storage 11.0.0",
+ "ethrex-storage 12.0.0",

There are still two packages (ethrex-common 1.0.0 and ethrex-storage 1.0.0) present alongside the bumped versions. These appear to be referenced by something in the tooling workspace that pins an old version. This was already present before this PR and is not a regression introduced here, but it is worth verifying that these old version references are intentional (e.g., a compatibility shim or test tool). If they are leftover, this would be the right time to clean them up as part of a major version bump.

Docs update is correct

docs/CLI.md has two occurrences of the --builder.extra-data default — one in the L1 section, one in the L2 section — and both were updated consistently.

Cherry-picked levm fixes not visible in the diff

The PR description references two levm bug fixes (restore_cache_state missing the exists flag restore, and no-op for zero-value balance changes). These are not present in the gh pr diff output, which suggests they were either committed to the release branch before the divergence point from main, or they landed on main independently. Before merging, confirm those commits are actually included in the branch (e.g. git log --oneline main..HEAD | grep -E 'd71b53d|36da5e1'), especially since the exists-flag fix carries correctness implications for EIP-7702 and Amsterdam+ refund accounting.

Summary

This is a clean, mechanical version bump with no logic changes visible in the diff. The versioning is consistent across all manifests and lockfiles. The one item to verify before merge is whether the two levm bug fixes are actually present in the branch, and whether the lingering 1.0.0 entries in tooling/Cargo.lock are intentional. No blocking issues found in the diff itself.

Automated review by Claude (Anthropic) · sonnet · custom prompt

Greptile Summary

This PR bumps the workspace version from 11.0.0 to 12.0.0 across all Cargo.toml files (root workspace, four guest programs, and the TEE quote-gen crate) and updates the docs/CLI.md default builder extra-data string to match. It also cherry-picks two levm correctness fixes into the release.

• exists flag restored on revert (utils.rs): restore_cache_state now restores current_account.exists from the backup, preventing a stale exists = true from persisting after a reverted transaction that touched a non-existent account. The backup-capture order in VM::get_account_mut and the SELFDESTRUCT hook was also reordered so the snapshot is taken before mark_modified() unconditionally sets exists = true.
• Zero-value balance changes short-circuit (gen_db.rs): increase_account_balance and decrease_account_balance now return early when the delta is zero, avoiding an unnecessary get_account_mut call that would mark the account as modified and pollute the revert cache.

Confidence Score: 5/5

This PR is safe to merge — the version bumps are consistent across all manifests and the two levm fixes address well-scoped correctness bugs in the revert and balance-change paths.

The version bump is mechanical and consistent across all Cargo.toml files and the CLI docs. The two cherry-picked levm fixes are narrowly scoped: restoring the exists field on revert correctly closes the stale-cache bug described in the PR, the backup reordering before mark_modified is the right fix and follows the same pattern in both get_account_mut and the SELFDESTRUCT hook, and the zero-delta early returns are safe optimisations with no observable behaviour change for non-zero inputs.

No files require special attention.

_{Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile}

🤖 Codex Code Review

Review

No findings. This is a mechanical release bump, and the exposed version surfaces are consistent: Cargo.toml moves the workspace to 12.0.0, the runtime/default CLI value still derives from CARGO_PKG_VERSION in cmd/ethrex/cli.rs, cmd/ethrex/cli.rs, and cmd/ethrex/utils.rs, and the regenerated help text matches in docs/CLI.md and docs/CLI.md.

The diff does not touch EVM execution, gas accounting, consensus checks, trie/storage code, or RLP logic, so I don’t see protocol or security risk in this PR. Static review only; cargo metadata --locked was blocked in this environment by rustup trying to write outside the writable roots.

Automated review by OpenAI Codex · gpt-5.4 · custom prompt

Lines of code report

Total lines added: 9
Total lines removed: 0
Total lines changed: 9

+-------------------------------------------------+-------+------+
| File                                            | Lines | Diff |
+-------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/db/gen_db.rs          | 561   | +7   |
+-------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/hooks/default_hook.rs | 459   | +1   |
+-------------------------------------------------+-------+------+
| ethrex/crates/vm/levm/src/utils.rs              | 461   | +1   |
+-------------------------------------------------+-------+------+

Benchmark Results Comparison

No significant difference was registered for any benchmark run.