docs(l2): fix broken Taiko links in based rollup references#6525
Conversation
The Link Check job fails on any PR touching docs/** because three Taiko links in docs/l2/fundamentals/based.md trip lychee: two docs.taiko.xyz URLs return 404, and one taiko.mirror.xyz URL is blocked by anti-bot protection (same behavior as medium.com, which is already excluded). - Update the "Based Rollups by Taiko" link to docs.taiko.xyz/protocol/based-rollups (current page on the Taiko docs site). - Remove the "Taiko Gwyneth" entry: returns 404, no successor found in the new docs. - Keep the taiko.mirror.xyz link (content is live, just bot-blocked) and exclude mirror.xyz from lychee, same treatment as the existing medium.com exclusion.
🤖 Claude Code ReviewPR #6525 Review:
|
🤖 Kimi Code ReviewReview for PR #6525 (Documentation link maintenance) Overall Assessment: Straightforward documentation maintenance PR. No code changes, only link updates and CI configuration. Specific Feedback:
Suggestion: If the Gwyneth content is truly gone, consider adding a note that Taiko Gwyneth was previously documented here but has been sunset/merged, rather than silent deletion, for historical context. No security or consensus issues - documentation only. Automated review by Kimi (Moonshot AI) · kimi-k2.5 · custom prompt |
Greptile SummaryThis PR fixes three broken Taiko links in Confidence Score: 5/5Safe to merge — targeted documentation and CI-config fix with no logic changes. All changes are purely documentation link updates and a lychee exclusion addition. No logic, security, or correctness concerns. All findings are P2 or lower. No files require special attention.
|
| Filename | Overview |
|---|---|
| .github/workflows/pr-main_mdbook.yml | Adds --exclude 'mirror.xyz' to the lychee link-checker arguments, mirroring the existing medium.com exclusion for bot-blocked sites. |
| docs/l2/fundamentals/based.md | Updates the "Based Rollups by Taiko" link to the current docs URL and removes the dead "Taiko Gwyneth" link. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR touches docs/**] --> B[Lint job - mdBook build]
B --> C[Link Check job - lychee]
C --> D{Link valid?}
D -->|excluded: localhost\nmedium.com\nmirror.xyz| E[Pass ✅]
D -->|404 / error| F[Fail ❌]
D -->|200 OK| E
Reviews (1): Last reviewed commit: "docs(l2): fix broken Taiko links in base..." | Re-trigger Greptile
There was a problem hiding this comment.
Pull request overview
Fixes broken/excluded external links in L2 “based rollup” documentation to keep the Link Check job passing while preserving relevant references.
Changes:
- Update the Taiko “Based Rollups” reference to the current Taiko docs URL.
- Remove the 404’ing “Taiko Gwyneth” reference.
- Exclude
mirror.xyzfrom lychee checks to avoid anti-bot failures ontaiko.mirror.xyz.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
docs/l2/fundamentals/based.md |
Updates/removes Taiko references to eliminate 404 links in the docs. |
.github/workflows/pr-main_mdbook.yml |
Adjusts lychee link-check arguments to exclude mirror.xyz (bot-blocked). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uses: lycheeverse/lychee-action@v2 | ||
| with: | ||
| args: --no-progress --exclude 'localhost' --exclude 'medium.com' docs/ | ||
| args: --no-progress --exclude 'localhost' --exclude 'medium.com' --exclude 'mirror.xyz' docs/ |
There was a problem hiding this comment.
lychee --exclude values are regular expressions; unescaped dots match any character. Since this line is being updated, consider escaping the dots so you exclude only the intended domains (e.g., medium\.com and mirror\.xyz, or even taiko\.mirror\.xyz for tighter scoping) rather than accidentally skipping URLs that just happen to match the regex.
| args: --no-progress --exclude 'localhost' --exclude 'medium.com' --exclude 'mirror.xyz' docs/ | |
| args: --no-progress --exclude 'localhost' --exclude 'medium\.com' --exclude 'mirror\.xyz' docs/ |
🤖 Codex Code Review
No other findings. This PR is docs/CI-only, and I don’t see any impact on execution correctness, gas accounting, consensus behavior, or Rust safety. I couldn’t verify the external URLs themselves locally because network access is restricted. Automated review by OpenAI Codex · gpt-5.4 · custom prompt |
…the Taiko-links docs fix from #6525. Conflict in .github/workflows/pr-main_mdbook.yml on the lychee exclude list resolved by unioning both sides: keep `--exclude 'stateless-validation.l2beat.com'` (added on this branch for the native rollup docs that link to the L2Beat native rollups page) and `--exclude 'mirror.xyz'` (added on main for taiko.mirror.xyz now linked from docs/l2/fundamentals/based.md). docs/l2/fundamentals/based.md auto-merged cleanly with main's link updates.
Motivation
The
Link Checkjob fails on any PR touchingdocs/**because three Taiko links indocs/l2/fundamentals/based.mdtrip lychee: twodocs.taiko.xyzURLs return 404, and onetaiko.mirror.xyzURL is blocked by anti-bot protection (same behavior asmedium.com, which is already excluded).Description
https://docs.taiko.xyz/protocol/based-rollups(current page on the Taiko docs site).taiko.mirror.xyzlink (content is live, just bot-blocked) and excludemirror.xyzfrom lychee, same treatment as the existingmedium.comexclusion.