feat: (levm) Implement calldata and returndata opcodes#574
Merged
Conversation
…ata-and-returndata-opcodes
lazcanoluca
approved these changes
Sep 30, 2024
lazcanoluca
left a comment
Contributor
There was a problem hiding this comment.
Just for the record, we discussed about changing the Memory type to plain Bytes in calldata and return_data, which was done.
Approving 🚀
ilitteri
reviewed
Sep 30, 2024
Comment on lines
+13
to
+15
| pub fn new_from_vec(data: Vec<u8>) -> Self { | ||
| Self { data } | ||
| } |
Collaborator
There was a problem hiding this comment.
Can't we implement From<Vec<u8>> for Memory?
…m:lambdaclass/ethereum_rust into levm/feat/calldata-and-returndata-opcodes
emirongrr
pushed a commit
to emirongrr/ethrex
that referenced
this pull request
Nov 10, 2024
**Motivation** Implemented `CALLDATALOAD`, `CALLDATASIZE`, `CALLDATACOPY`, `RETURNDATASIZE`, `RETURNDATACOPY` **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 --> Closes lambdaclass#517 Closes lambdaclass#518 Closes lambdaclass#519 Closes lambdaclass#525 Closes lambdaclass#526 --------- Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Implemented
CALLDATALOAD,CALLDATASIZE,CALLDATACOPY,RETURNDATASIZE,RETURNDATACOPYDescription
Closes #517
Closes #518
Closes #519
Closes #525
Closes #526