feat: (levm) block information opcodes#565
Merged
Merged
Conversation
…/feat/block_information
…/feat/block_information
lazcanoluca
reviewed
Sep 27, 2024
Contributor
There was a problem hiding this comment.
The implementation of the opcodes looks good to me, and so does the db.
As for the many comments I left, they are mostly nitpicks, nothing major. Mostly renaming some stuff to match the yellow paper, proposing changes to the comments, and proposing the deletion of stuff we don't yet need. Of course, let me know if you don't agree with the changes or if the propositions are too nitpicky.
I'd like to hear the input from a code owner about this. nevermind
lazcanoluca
reviewed
Sep 27, 2024
Co-authored-by: Luca Lazcano <64329820+lazcanoluca@users.noreply.github.com>
Co-authored-by: Luca Lazcano <64329820+lazcanoluca@users.noreply.github.com>
Co-authored-by: Luca Lazcano <64329820+lazcanoluca@users.noreply.github.com>
Co-authored-by: Luca Lazcano <64329820+lazcanoluca@users.noreply.github.com>
Co-authored-by: Luca Lazcano <64329820+lazcanoluca@users.noreply.github.com>
Co-authored-by: Luca Lazcano <64329820+lazcanoluca@users.noreply.github.com>
ilitteri
reviewed
Sep 27, 2024
ilitteri
reviewed
Sep 30, 2024
ilitteri
reviewed
Sep 30, 2024
ilitteri
reviewed
Sep 30, 2024
ilitteri
reviewed
Sep 30, 2024
ilitteri
left a comment
Collaborator
There was a problem hiding this comment.
Great work! We're close to merge it. Left some comments.
Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com>
Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com>
Co-authored-by: Luca Lazcano <64329820+lazcanoluca@users.noreply.github.com>
emirongrr
pushed a commit
to emirongrr/ethrex
that referenced
this pull request
Nov 10, 2024
**Motivation** Adds most of block information opcodes to the VM **Description** - Adds the implementation of all block information opcodes except selfbalance and blobhash, which needs the implementation of accounts and transactions - Adds tests for the implemented opcodes <!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 --> Closes lambdaclass#502 Closes lambdaclass#503 Closes lambdaclass#504 Closes lambdaclass#505 Closes lambdaclass#506 Closes lambdaclass#507 Closes lambdaclass#508 Closes lambdaclass#510 Closes lambdaclass#511 --------- Co-authored-by: Luca Lazcano <64329820+lazcanoluca@users.noreply.github.com> Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds most of block information opcodes to the VM
Description
Closes #502
Closes #503
Closes #504
Closes #505
Closes #506
Closes #507
Closes #508
Closes #510
Closes #511