Skip to content

feat(levm): KECCAK256 opcode#561

Merged
ilitteri merged 3 commits into
mainfrom
levm/feat/keccak256
Sep 26, 2024
Merged

feat(levm): KECCAK256 opcode#561
ilitteri merged 3 commits into
mainfrom
levm/feat/keccak256

Conversation

@juanimedone

@juanimedone juanimedone commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

Motivation
Implement and test the KECCAK256 opcode.

Description

  • Add sha3 dependency.
  • Write new Memory::load_range function.
  • Implement the operation's logic.
  • Test different case scenarios.

Closes #482.

@juanimedone juanimedone self-assigned this Sep 25, 2024
@juanimedone juanimedone linked an issue Sep 25, 2024 that may be closed by this pull request
@juanimedone juanimedone marked this pull request as ready for review September 25, 2024 21:32
@juanimedone juanimedone requested a review from a team as a code owner September 25, 2024 21:32

@belfortep belfortep left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ilitteri ilitteri added this pull request to the merge queue Sep 26, 2024

@iinaki iinaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left that comment, change only if if you feel like it, otherwise nice work!

Comment thread crates/levm/tests/tests.rs
Merged via the queue into main with commit 5440e2c Sep 26, 2024
@ilitteri ilitteri deleted the levm/feat/keccak256 branch September 26, 2024 13:03
emirongrr pushed a commit to emirongrr/ethrex that referenced this pull request Nov 10, 2024
**Motivation**
Implement and test the `KECCAK256` opcode.
<!-- Why does this pull request exist? What are its goals? -->

<!-- A clear and concise general description of the changes this PR
introduces -->
**Description**
- Add `sha3` dependency.
- Write new `Memory::load_range` function.
- Implement the operation's logic.
- Test different case scenarios.

<!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 -->
Closes lambdaclass#482.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opcode: KECCAK256

4 participants