Skip to content

feat(levm): comparison opcodes#547

Merged
juanimedone merged 12 commits into
mainfrom
levm/feat/comparison-opcodes
Sep 25, 2024
Merged

feat(levm): comparison opcodes#547
juanimedone merged 12 commits into
mainfrom
levm/feat/comparison-opcodes

Conversation

@juanimedone

@juanimedone juanimedone commented Sep 24, 2024

Copy link
Copy Markdown
Contributor

Description
Implements and unit tests the following comparison opcode operations:

  • LT
  • GT
  • SLT
  • SGT
  • EQ
  • ISZERO

Closes #468, #469, #470, #471, #472 and #473.

@juanimedone juanimedone changed the title feat: (levm) comparison opcodes feat(levm): comparison opcodes Sep 25, 2024
@juanimedone juanimedone marked this pull request as ready for review September 25, 2024 13:55
@juanimedone juanimedone requested a review from a team as a code owner September 25, 2024 13:55
@juanimedone juanimedone self-assigned this Sep 25, 2024
Comment thread crates/levm/src/vm.rs
This was linked to issues Sep 25, 2024

@lazcanoluca lazcanoluca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

Comment thread crates/levm/src/utils.rs Outdated

@ilitteri ilitteri left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilitteri ilitteri enabled auto-merge September 25, 2024 18:20
@ilitteri ilitteri added this pull request to the merge queue Sep 25, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 25, 2024
@juanimedone juanimedone added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 7e2b361 Sep 25, 2024
@juanimedone juanimedone deleted the levm/feat/comparison-opcodes branch September 25, 2024 19:22
emirongrr pushed a commit to emirongrr/ethrex that referenced this pull request Nov 10, 2024
<!-- Why does this pull request exist? What are its goals? -->

<!-- A clear and concise general description of the changes this PR
introduces -->
**Description**
Implements and unit tests the following comparison opcode operations:
- `LT`
- `GT`
- `SLT`
- `SGT`
- `EQ`
- `ISZERO`

<!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 -->
Closes lambdaclass#468, lambdaclass#469, lambdaclass#470, lambdaclass#471, lambdaclass#472 and lambdaclass#473.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opcode: EQ Opcode: SGT Opcode: SLT Opcode: GT Opcode: LT

3 participants