feat: remove Mutex from Store#441
Merged
Merged
Conversation
Mutex from StoreMutex from Store
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 7, 2025
This comment references a refactor that has been already implemented #441
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
This comment references a refactor that has been already implemented lambdaclass#441
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, our Store contains an
Arc<Mutex<dyn StoreEngine>>, but the mutex is not really needed for the libmbdx backend, it is only needed for the InMemory one. This means we should be able to move the mutex into the in memory engine and leave the libmdbx mutex-free.This PR proposes moving this mutex into the InMemory engine and changing the structure of
Storeto:Description
Store.enginetype fromArc<Mutex<dyn StoreEngine>>toE: StoreEngine,Arc<Mutex<>>StoreEnginetoLibmdbxStoreEngine&InMemoryStoreEngineand expose them publiclynew_tempforStoreto be used in tests instead of creating and removing directories "by hand".Closes #issue_number