fix(l1,l2): extract Rust version from rust-toolchain.toml for all CI runs#3318
Closed
klaus993 wants to merge 6 commits into
Closed
fix(l1,l2): extract Rust version from rust-toolchain.toml for all CI runs#3318klaus993 wants to merge 6 commits into
klaus993 wants to merge 6 commits into
Conversation
To remove the usage of the RUST_VERSION GitHub Variable. GitHub Variables are excluded from workflow runs triggered by PRs from forks, so we need to remove this variable dependency in order for external collaborators to send PRs and run the CI
So the rust-toolchain.toml file is present
Benchmark Results ComparisonPR ResultsBenchmark Results: Factorial
Benchmark Results: Factorial - Recursive
Benchmark Results: Fibonacci
Benchmark Results: ManyHashes
Benchmark Results: BubbleSort
Benchmark Results: ERC20 - Transfer
Benchmark Results: ERC20 - Mint
Benchmark Results: ERC20 - Approval
Main ResultsBenchmark Results: Factorial
Benchmark Results: Factorial - Recursive
Benchmark Results: Fibonacci
Benchmark Results: ManyHashes
Benchmark Results: BubbleSort
Benchmark Results: ERC20 - Transfer
Benchmark Results: ERC20 - Mint
Benchmark Results: ERC20 - Approval
|
Benchmark for a387196Click to view benchmark
|
Benchmark Block Execution Results Comparison Against Main
|
mpaulucci
reviewed
Jun 26, 2025
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Rustup toolchain install | ||
| - name: Extract Rust version from rust-toolchain.toml |
Collaborator
There was a problem hiding this comment.
can't you make a reusable job so we don't have to copy paste this everywhere? Like a reusable Install Rust job that takes the value from the rust-roolchain.
Benchmark for 20b4c8bClick to view benchmark
|
Collaborator
|
I have this one to reemplace #3591 with a more DRY approach |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
Continuation of #3318 **Motivation** GitHub Variables are excluded from workflow runs triggered by PRs from forks, so we need to remove this variable dependency in order for external collaborators to send PRs and run the CI properly **Description** * The `Extract Rust version from rust-toolchain.toml` step (`id: rustver`) uses `grep` and `sed` to extract the rust version from the `rust-toolchain.toml` file that is in the root of the repository. * The `Install Rust` step utilizes the output of the previous step to send the version to the `toolchain` parameter * Note that in some cases, I had to move the `Checkout` step further up (it's also good practice to put it as high up as possible) so the `rust-toolchain.toml` file is available to be read. --------- Co-authored-by: Klaus Lungwitz <klaus.lungwitz@lambdaclass.com> Co-authored-by: Javier Rodríguez Chatruc <49622509+jrchatruc@users.noreply.github.com>
d-roak
pushed a commit
to 1sixtech/ethrex
that referenced
this pull request
Jul 17, 2025
Continuation of lambdaclass#3318 **Motivation** GitHub Variables are excluded from workflow runs triggered by PRs from forks, so we need to remove this variable dependency in order for external collaborators to send PRs and run the CI properly **Description** * The `Extract Rust version from rust-toolchain.toml` step (`id: rustver`) uses `grep` and `sed` to extract the rust version from the `rust-toolchain.toml` file that is in the root of the repository. * The `Install Rust` step utilizes the output of the previous step to send the version to the `toolchain` parameter * Note that in some cases, I had to move the `Checkout` step further up (it's also good practice to put it as high up as possible) so the `rust-toolchain.toml` file is available to be read. --------- Co-authored-by: Klaus Lungwitz <klaus.lungwitz@lambdaclass.com> Co-authored-by: Javier Rodríguez Chatruc <49622509+jrchatruc@users.noreply.github.com>
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
Continuation of lambdaclass#3318 **Motivation** GitHub Variables are excluded from workflow runs triggered by PRs from forks, so we need to remove this variable dependency in order for external collaborators to send PRs and run the CI properly **Description** * The `Extract Rust version from rust-toolchain.toml` step (`id: rustver`) uses `grep` and `sed` to extract the rust version from the `rust-toolchain.toml` file that is in the root of the repository. * The `Install Rust` step utilizes the output of the previous step to send the version to the `toolchain` parameter * Note that in some cases, I had to move the `Checkout` step further up (it's also good practice to put it as high up as possible) so the `rust-toolchain.toml` file is available to be read. --------- Co-authored-by: Klaus Lungwitz <klaus.lungwitz@lambdaclass.com> Co-authored-by: Javier Rodríguez Chatruc <49622509+jrchatruc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
GitHub Variables are excluded from workflow runs triggered by PRs from forks, so we need to remove this variable dependency in order for external collaborators to send PRs and run the CI properly
Description
Extract Rust version from rust-toolchain.tomlstep (id: rustver) usesgrepandsedto extract the rust version from therust-toolchain.tomlfile that is in the root of the repository.Install Ruststep utilizes the output of the previous step to send the version to thetoolchainparameterCheckoutstep further up (it's also good practice to put it as high up as possible) so therust-toolchain.tomlfile is available to be read.