fix(core): fix Trie::verify_range for proof of absences.#3146
Merged
Conversation
Lines of code reportTotal lines added: Detailed view |
Benchmark for 3bb9b68Click to view benchmark
|
Trie::verify_range for proof of absences.Trie::verify_range for proof of absences.
Benchmark for 3ad3a11Click to view benchmark
|
Arkenan
approved these changes
Jun 13, 2025
| proof, | ||
| root.into(), | ||
| (*first_key, Some(*last_key)), | ||
| Some(*keys.first().unwrap()), |
Collaborator
There was a problem hiding this comment.
nit: maybe this can be improved if instead of unwrapping we do something like
if let [key] = keys.as_slice() {
if first_key != *key {
return Err(TrieError::Verify(
"correct proof but invalid key".to_string(),
));
}
// ...
}this way we avoid the unwrap, plus the last_key is also guaranteed to be "key" if it exists.
fmoletta
approved these changes
Jun 13, 2025
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
…ss#3146) **Motivation** <!-- Why does this pull request exist? What are its goals? --> **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 --> Closes #issue_number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Closes #issue_number