chore(l1,l2): ordered genesis files#2713
Merged
Merged
Conversation
Lines of code reportTotal lines added: Detailed view |
mpaulucci
requested changes
May 9, 2025
mpaulucci
left a comment
Collaborator
There was a problem hiding this comment.
not sure I agree with this approach, now we're mixing fork specific configs like "muirGlacierBlock" with other configs like "depositContractAddress". What is the standard across Ethereum? I have never seen it be alphabetically ordered keys
mpaulucci
reviewed
May 12, 2025
Arkenan
approved these changes
May 12, 2025
31fe9fe to
14cc4dc
Compare
mpaulucci
reviewed
May 15, 2025
| ethereum-types.workspace = true | ||
| serde.workspace = true | ||
| serde_json.workspace = true | ||
| # Preserve order is used to serialize the Genesis struct |
Collaborator
There was a problem hiding this comment.
why do we have to change a dependency in common for tooling? I thought we wanted to decouple them
mpaulucci
reviewed
May 15, 2025
| } | ||
| } | ||
|
|
||
| fn sort_config(genesis_map: &mut Map<String, Value>) -> Result<Map<String, Value>, String> { |
Collaborator
There was a problem hiding this comment.
can't we move this code to the tooling part
mpaulucci
approved these changes
May 15, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 16, 2025
**Motivation** Some changes (probably #2713) undid the fixed changes for the load test genesis file, this PR restores it.
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** Ordered genesis files make it easy to diff with one another. **Description** - Add function to write a Genesis json file with its keys ordered. - Genesis files are now ordered by key. Closes lambdaclass#2706.
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** Some changes (probably lambdaclass#2713) undid the fixed changes for the load test genesis file, this PR restores it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Ordered genesis files make it easy to diff with one another.
Description
Closes #2706.