feat(l2): hardcode SP1 verification key#2708
Merged
Merged
Conversation
The remaining configs are only used by the deployer and will be needless after we implement a separate CLI for it
…rex into replace_sequencer_config
jrchatruc
requested changes
May 15, 2025
jrchatruc
left a comment
Collaborator
There was a problem hiding this comment.
PR is good but we need to make sure that in dev mode people don't need to build the SP1 binary to setup everything
Contributor
Author
|
made 0x00..00 the default verification key so that it's not necessary to build any zkvm if running with exec backend |
Contributor
|
Tested in my machine in dev mode and works! When testing with sp1 on the server, the first run fails with: That first run modifies |
Contributor
Author
|
We found that @avilagaston9's error was in main: #2839 |
jrchatruc
approved these changes
May 20, 2025
avilagaston9
approved these changes
May 20, 2025
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** Instead of sending it as a parameter, it will be set as a contract static variable. Also makes sp1 build in docker for reproducibility (and so the key doesn't change depending on the platform we're building) --------- Co-authored-by: ilitteri <ilitteri@fi.uba.ar> Co-authored-by: Ivan Litteri <67517699+ilitteri@users.noreply.github.com> Co-authored-by: Javier Rodríguez Chatruc <49622509+jrchatruc@users.noreply.github.com> Co-authored-by: Manuel Iñaki Bilbao <manuel.bilbao@lambdaclass.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Instead of sending it as a parameter, it will be set as a contract static variable.
Also makes sp1 build in docker for reproducibility (and so the key doesn't change depending on the platform we're building)