chore(l1): update execution spec tests 4.0.0 -> 4.3.0#2586
Merged
Conversation
After updating to version 4.3.0 of the executions tests, there are 12 new tests that fail on REVM.
Version 4.3.0 of execution spec tests adds new tests that fail when using LEVM. Thos where added to the array so they can be skipped.
Lines of code reportTotal lines added: Detailed view |
mpaulucci
approved these changes
Apr 24, 2025
tomip01
approved these changes
Apr 25, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 8, 2025
**Motivation** On #2586 new tests were added and some of them failed on LEVM and REVM. **Description** 8 new tests are now working and dont need to be skipped in each of the VMs. The tests were failing because we were not checking if the bytecode of the system contracts that the EIPs ([7002](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7002.md#empty-code-failure) and [7251](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7251.md)) define were empty or not. And also because the we were not handling the case were the system calls revert, leading to an invalidate block. Closes #2598 --------- Co-authored-by: Jeremías Salomón <48994069+JereSalo@users.noreply.github.com>
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** A new [release](https://github.com/ethereum/execution-spec-tests/releases/tag/v4.3.0) on the execution spec tests introduces more coverage for Prague EIPs. **Description** When executing `make tests` now the new 4.3.0 version of the tests is used. As more tests where added in this version, some of them failed so they where added to the skipped array. Closes lambdaclass#2513
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
) **Motivation** On lambdaclass#2586 new tests were added and some of them failed on LEVM and REVM. **Description** 8 new tests are now working and dont need to be skipped in each of the VMs. The tests were failing because we were not checking if the bytecode of the system contracts that the EIPs ([7002](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7002.md#empty-code-failure) and [7251](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7251.md)) define were empty or not. And also because the we were not handling the case were the system calls revert, leading to an invalidate block. Closes lambdaclass#2598 --------- Co-authored-by: Jeremías Salomón <48994069+JereSalo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A new release on the execution spec tests introduces more coverage for Prague EIPs.
Description
When executing
make testsnow the new 4.3.0 version of the tests is used. As more tests where added in this version, some of them failed so they where added to the skipped array.Closes #2513