refactor(l1): remove usage of assert_eq in frame decoding (rlpx)#2456
Merged
Conversation
Lines of code reportTotal lines added: Detailed view |
assert_eq in frame decoding (rlpx)
rodrigo-o
approved these changes
Apr 16, 2025
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
…ambdaclass#2456) **Motivation** Replaces `assert_eq` usage with proper errors in rlpx frame decoding <!-- Why does this pull request exist? What are its goals? --> **Description** * Add error variant `RLPXError::InvalidMessageFrame` * Remove usage of `assert_eq` in `RLPxCodec::decode` impl <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 --> Closes lambdaclass#1748
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Replaces
assert_equsage with proper errors in rlpx frame decodingDescription
RLPXError::InvalidMessageFrameassert_eqinRLPxCodec::decodeimplCloses #1748