perf(levm): remove repeated get_account_info calls in LEVM#2357
Merged
Conversation
Lines of code reportTotal lines added: Detailed view |
AccountInfo to reduce get_account_info callsAccountInfo to reduce get_account_info calls
AccountInfo to reduce get_account_info callsget_account_info calls in LEVM
fborello-lambda
approved these changes
Mar 31, 2025
jrchatruc
approved these changes
Mar 31, 2025
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
…lass#2357) **Motivation** Noticed on lambdaclass#2292 that the majority of the time in `LEVM::get_state_transitions()` was spent on calls to `get_account_info()`. While looking for areas to improve, I found that we were calling `get_account_info()` three times instead of reusing the value returned in the first call. **Description** Removes the repeated calls to `get_account_info`. Testing locally shows a `2x` speed improvement in `payload_builder::build_payload()` implemented in lambdaclass#2292. Closes None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Noticed on #2292 that the majority of the time in
LEVM::get_state_transitions()was spent on calls toget_account_info(). While looking for areas to improve, I found that we were callingget_account_info()three times instead of reusing the value returned in the first call.Description
Removes the repeated calls to
get_account_info.Testing locally shows a
2xspeed improvement inpayload_builder::build_payload()implemented in #2292.Closes None