Add metrics for execution and storage times per block#2302
Merged
Conversation
Lines of code reportTotal lines added: Detailed view |
mpaulucci
reviewed
Mar 25, 2025
Oppen
reviewed
Apr 18, 2025
| }; | ||
|
|
||
| let result = inner().await; | ||
| let res = self.execute_block(block).await?; |
Contributor
There was a problem hiding this comment.
Note that now there will be no log if execution fails. It sounds reasonable but it's not the original behavior.
Oppen
approved these changes
Apr 18, 2025
fkrause98
approved these changes
Apr 21, 2025
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
This PR adds logs for each imported block: - Transaction count - ms/Ggas for execution - ms/Ggas for storage - Percentage between execution and storage in an imported block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds logs for each imported block: