test: fix EF tests that transition from one network to another.#230
Merged
Conversation
fmoletta
approved these changes
Aug 8, 2024
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
**Motivation** Fix ef_tests where the fork transition occurs within a single test **Description** Changes the timestamp check for tests with network "ShanghaiToCancunAtTime15k" : From: `if block.header.timestamp > 15_000` To: `if block.header.timestamp >= 15_000` Gets all tests from eip4788_beacon_root eip7516_blobgasfee eip4895_withdrawals to pass again. Fix for this pr: #230
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We shouldn't skip tests that have a network that we don't recognize
Description
Fixes tests for the different netoworks. Panics if a network is not recognized.