feat: ef_tests now compares state_root in poststate checks#226
Merged
Conversation
fmoletta
approved these changes
Aug 9, 2024
vicentevieytes
pushed a commit
that referenced
this pull request
Aug 12, 2024
**Motivation** Some ef-tests are failing on the state root poststate checks. This fixes the issues **Description** Some corrections are included in order to fix some tests that started to fail - Removes zero values from account storage trie - Do not create empty accounts - Check stateRoot from last valid blocks (ie. discards invalid blocks in tests that check exceptions) Closes #45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some ef-tests are failing on the state root poststate checks. This fixes the issues
Description
Some corrections are included in order to fix some tests that started to fail
Closes #45