feat(l1) add holesky presets#1601
Merged
Merged
Conversation
mpaulucci
reviewed
Jan 3, 2025
| @@ -0,0 +1,1015 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
nit: maybe move to networks/holesky/genesis.json?
mpaulucci
reviewed
Jan 8, 2025
|
|
||
| pub const HOLESKY_GENESIS_PATH: &str = "cmd/ethrex/networks/holesky/genesis.json"; | ||
|
|
||
| lazy_static! { |
Collaborator
There was a problem hiding this comment.
maybe we can move the bootnodes to networks/holesky/bootnodes.json?
Collaborator
There was a problem hiding this comment.
I want that just adding a new network means adding a couple of json files in networks/{network_name}
|
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** <!-- Why does this pull request exist? What are its goals? --> **Description** <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 --> Closes lambdaclass#1596
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Closes #1596