feat: fetch block numbers in store api + refactor: remove unwraps from libmdx impl of store#150
Merged
Conversation
…-block-number-table
…-block-number-table
ElFantasma
reviewed
Jul 16, 2024
ElFantasma
reviewed
Jul 16, 2024
ElFantasma
reviewed
Jul 16, 2024
MegaRedHand
pushed a commit
that referenced
this pull request
Jul 18, 2024
…#145) Based on #150, please merge it first **Motivation** Comply with rpc spec for `eth_getBlockByNumber` & `eth_getBlockByHash` <!-- Why does this pull request exist? What are its goals? --> **Description** * Integrate `Store` as a state for the rpc api * Add RPC endpoints `eth_getBlockByNumber` & `eth_getBlockByHash` <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> Closes #31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #146, please merge it first
Motivation
Add a way to fetch blocks from their hashes (as blocks are stored by number this translates to adding a block_hash -> block_number mapping)
Description
get_block_number&add_block_numbermethods toStore(both using block_hash as key)StoreCloses None, but is needed in order to implement #31