fix(levm): fix transfer value in call, organize call opcodes and other fixes#1492
Merged
Conversation
This reverts commit 9f9ac2e.
maximopalopoli
approved these changes
Dec 13, 2024
maximopalopoli
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Now you can also move generic_call to system.rs, as you said before.
LeanSerra
approved these changes
Dec 13, 2024
LeanSerra
left a comment
Contributor
There was a problem hiding this comment.
LGTM, left a small comment
ilitteri
approved these changes
Dec 16, 2024
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
…r fixes (lambdaclass#1492) **Motivation** <!-- Why does this pull request exist? What are its goals? --> **Description** - Removes in `generic_call` double definition of `should_transfer_value` - Organizes call opcodes - Now we don't return early when bytecode is empty. This was inaccurate behavior <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves lambdaclass#111, Resolves lambdaclass#222 --> Closes #issue_number
edg-l
added a commit
that referenced
this pull request
May 13, 2026
ethrex ab15f37 hardened the HTTP JSON-RPC defaults, gating `admin_*`/`debug_*`/`txpool_*` behind a new `--http.api` allowlist. Hive c4d839b3 (#1485) feature-detects the flag in `clients/ethrex/ ethrex.sh` and opts those namespaces back in. The pinned version `1c27560a` predates that fix, so hive runs against current main start ethrex without the namespace allowlist and any test touching the gated namespaces gets `MethodNotFound`. Bump to current hive HEAD (3b6bde03), which includes the fix plus a Cargo.lock dependency-drift safeguard (#1492).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Removes in
generic_calldouble definition ofshould_transfer_valueOrganizes call opcodes
Now we don't return early when bytecode is empty. This was inaccurate behavior
Closes #issue_number