feat: add EIP4844 transactions#140
Merged
Merged
Conversation
MegaRedHand
approved these changes
Jul 11, 2024
| #[error("UnexpectedString")] | ||
| UnexpectedString, | ||
| #[error("Invalid transaction type")] | ||
| InvalidTransactionType, |
Collaborator
There was a problem hiding this comment.
This doesn't belong here.
| 0x3 => { | ||
| EIP4844Transaction::decode(tx_bytes).map(Transaction::EIP4844Transaction) | ||
| } | ||
| _ => Err(RLPDecodeError::InvalidTransactionType), |
Collaborator
There was a problem hiding this comment.
Can we change the return type, or return MalformedData instead?
Contributor
Author
There was a problem hiding this comment.
Could we use the custom variant? It is a shame to lose key information useful for debugging
Collaborator
There was a problem hiding this comment.
Sure! I think we might want to have some "stacktrace" in the future for cases like this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #138 (as they modify the same code), please merge it first
Motivation
Add support for EIP4844 transactions
Description
Add
EIP4844transactions + needed trait and methods and integrate it into existing transaction-related codeCloses #26 (evm already performs validations before executing so adding the transaction itself will sufice)