Merged
Conversation
Collaborator
|
I think this change makes sense. |
Member
Author
|
Apparently some of the tests don't actually test on the current commit. As a remedy, rebasing onto current main (and squashing in the process). |
The test matrix reduction is formal only, and does not reduce actual coverage: The features that were enabled merely enabled whether or not additive components got built, and nothing in the no_std tests actually used the imports (so the builds would be identical except that a crate was built in half the time, which is now always built in).
Member
Author
|
CI passed, & squashed. I think it's ready. |
Collaborator
|
Looks good, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think the lakers-ead crate is necessary any more: Since EADs are now driven by the application, they can be additive (one build test can contain them all). The test matrix was reduced as part of this because the tested applications did not actually pull code from the crate that toggled its content (couldn't either, because crates don't see feature flags of dependencies, they can only set them).
I probably missed some spots in the code during the cleanup, waiting for CI to show me where.
(Pleas only look at the last commit; the rest is actually #235, which was my starting point)