examples/coap: Update to new traits#235
Merged
geonnave merged 4 commits intolake-rs:mainfrom Mar 6, 2024
Merged
Conversation
This vastly enhances error handling.
Member
Author
|
Enhancing around the handling of EDHOCError is probably a more gradual thing, so I'm marking this as ready for review as it is (yes there are FIXMEs in the code, but those are still better than the panics that were in their place in the last iteration). |
Merged
geonnave
reviewed
Mar 6, 2024
geonnave
reviewed
Mar 6, 2024
Collaborator
|
Looks good, left two comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This vastly enhances error handling.
This is still a PR because I think that EDHOCError should become renderable, so that EDHOC errors can fly out through
?.