Merged
Conversation
f026645 to
80dcc1f
Compare
Collaborator
Author
|
Pulling the structs from other crates in the workspace works fine with |
moved ffi structs into the shared crate to be able to write `to_c` methods in the rust structs without having to set its fields visibility to public
80dcc1f to
955243e
Compare
0e640ba to
7c75a28
Compare
4825f76 to
4ee3231
Compare
4ee3231 to
b10dd32
Compare
7c7079e to
a61ad17
Compare
846c021 to
83e13e2
Compare
2e734b4 to
1f063b2
Compare
1f063b2 to
77c4611
Compare
7b88148 to
58c9006
Compare
58c9006 to
8c43514
Compare
lakers-ffilakers-c
Collaborator
Author
|
This is ready for review / merge. For an overview on the API and the integration with |
malishav
reviewed
Jan 31, 2024
- use curly brackets even on single line while - fix bug on macos with socket addr - improve readme and build.sh
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #180.
Since now the crypto backends are dissociated from the main crate, I had to add a new, separate crate that will import
lakersandlakers_crypto. One good implication of this approach is that this new crate can be hardcoded tocrate-type = ["staticlib"](in the previous version, I had to manually change from "rlib" to "staticlib" everytime I wanted to build the static version). On the other hand, I still need to figure whethercbindgenwill actually work across thelakers_ffi, lakers, and lakers_sharedcrates and generate all the needed headers.