Timeout mw: rework how test waits for timeout. Using sleep as delay i…#2187
Merged
aldas merged 2 commits intolabstack:masterfrom May 21, 2022
Merged
Timeout mw: rework how test waits for timeout. Using sleep as delay i…#2187aldas merged 2 commits intolabstack:masterfrom
aldas merged 2 commits intolabstack:masterfrom
Conversation
…s problematic when CI worker is slower than usual.
051080b to
a9c75d5
Compare
…s problematic when CI worker is slower than usual.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timeout mw: rework how test waits for timeout. Using sleep as delay is problematic when CI worker is slower than usual. Also make sure we wait logger middleware to be actually executed before we start asserting logger buffer contents.
Still having problems with macos-latest @ Go 1.18 runs