Add new value binding methods (UnixTimeMilli,TextUnmarshaler,JSONUnmarshaler) to Valuebinder#2127
Merged
aldas merged 2 commits intolabstack:masterfrom Mar 17, 2022
Merged
Conversation
…rshaler) to ValueBinder
3364542 to
7e32ac4
Compare
Codecov Report
@@ Coverage Diff @@
## master #2127 +/- ##
==========================================
+ Coverage 92.10% 92.21% +0.11%
==========================================
Files 37 37
Lines 3028 3071 +43
==========================================
+ Hits 2789 2832 +43
Misses 150 150
Partials 89 89
Continue to review full report at Codecov.
|
Contributor
Author
|
@lammel please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new value binding methods (UnixTimeMilli,TextUnmarshaler,JSONUnmarshaler) to Valuebinder. As it adds only new methods to struct it is backwards compatible change.
UnixTimeMillibinds1647184410140to2022-03-13T15:13:30.140000000+00:00useful when dealing with JavascriptTextUnmarshalerbinds value to destination implementingencoding.TextUnmarshalerinterfaceJSONUnmarshalerbinds value to destination implementingjson.UnmarshalerinterfaceRequested in #2000 (comment)