fix: realign Rust MSRV to 1.93 for Launchpad PPA builds#238
Merged
Conversation
sysinfo 0.39 raised the effective MSRV to 1.95, but no Rust 1.95 toolchain
is available for the target Ubuntu series: resolute ships rustc/cargo 1.93.1,
and the lablup rustc-release PPA tops out at rustc-1.94. The debian/control
build-dep "rustc-1.95 | rustc (>= 1.95)" was therefore unsatisfiable and the
Launchpad PPA build would fail (dep-wait) on resolute, jammy and noble.
Changes:
- Revert sysinfo 0.39 -> 0.38 (0.38.4, MSRV 1.88); highest dependency MSRV
is now 1.88, so nothing requires more than 1.93.
- Set package rust-version = 1.93 and align Dockerfile (rust:1.93-slim) and
all debian packaging (control, control.source, rules*, README.packaging).
- Make the Launchpad toolchain selection forward-compatible:
- build-deps widened to
"rustc-1.93 | rustc-1.94 | rustc-1.95 | rustc (>= 1.93)" (cargo likewise)
- debian/rules now auto-detects the newest available toolchain among
rustc-1.95 / rustc-1.94 / rustc-1.93, falling back to the unversioned
rustc, with a ">= 1.93" guard validating whichever is selected.
This way any published toolchain >= 1.93 (in the archive or the PPA) builds
without further packaging edits.
Verification:
- cargo check --all-targets --locked on Rust 1.88.0 (strictest floor) passes;
sysinfo 0.38 API is fully compatible with the code.
- debian/rules detection exercised through make for the fallback, 1.93 and
1.95-preferred cases.
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sysinfo 0.39(pulled in by #228) raised the effective MSRV to 1.95, and #233 propagatedrustc-1.95into the Debian packaging. But no Rust 1.95 toolchain is actually available for the target Ubuntu series:rustc/cargo1.93.1, versioned up torustc-1.93rustc-releasePPA tops out atrustc-1.94rustc-1.95So the build-dep
rustc-1.95 | rustc (>= 1.95)is unsatisfiable and the Launchpad PPA build would fail (dep-wait) on all three series.Fix
Lower the baseline to Rust 1.93 (what resolute ships natively and what the PPA can provide via
rustc-1.93):sysinfo0.39 → 0.38(resolves to0.38.4, MSRV 1.88). After this the highest dependency MSRV is 1.88, so nothing needs more than 1.93. The 0.39-onlyobjc2/dispatch2subtree is dropped fromCargo.lock.rust-version = "1.93"; alignDockerfile(rust:1.93-slim) and all debian packaging.Make toolchain selection forward-compatible so future PPA bumps don't need packaging edits:
rustc-1.93 | rustc-1.94 | rustc-1.95 | rustc (>= 1.93)(cargo likewise). APT picks the first installable alternative.debian/rulesauto-detects the newest available toolchain (rustc-1.95→1.94→1.93→ unversionedrustc), keeping the>= 1.93guard that validates whichever is selected.Verification
cargo check --all-targets --lockedon Rust 1.88.0 (the strict dependency floor) passes — confirms sysinfo 0.38 API compatibility and that the code builds well below 1.93.debian/rulesdetection exercised throughmakefor the fallback / 1.93 / 1.95-preferred cases (correct selection in all three).Files
Cargo.toml,Cargo.lock,Dockerfile,.github/workflows/launchpad_ppa.yml,debian/control(.source),debian/rules(.source,.launchpad,.launchpad-simple),debian/README.packaging.