fix: align Docker Rust toolchain with MSRV#233
Merged
Conversation
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Docker Build Check failure introduced after the dependency refresh to
sysinfo 0.39.2, which requires Rust 1.95 while the Docker builder image was still pinned to Rust 1.88.Changes
rust:1.88-slimtorust:1.95-slim.FROM ... AScasing warning reported by buildx.rust-version = "1.95".Build Check Note
The regular CI
Build Checkrunscargo build --release --bin all-smifirst and thencargo build --no-default-features --lib. Those two can fail independently because the library-only build compiles a different feature set. The current Docker failure is separate: the Dockerfile only runs the binary release build, and it failed before compilation because Cargo rejectedsysinfo 0.39.2on rustc 1.88.Validation
cargo metadata --format-version 1 --locked --no-depscargo fmt --checkgit diff --checkLIBRARY_PATH=/home/inureyes/Development/backend.ai/all-smi/target/local-lib cargo build --release --bin all-smiLIBRARY_PATH=/home/inureyes/Development/backend.ai/all-smi/target/local-lib cargo build --no-default-features --libLIBRARY_PATH=/home/inureyes/Development/backend.ai/all-smi/target/local-lib cargo clippy -- -D warningsLocal Docker validation was attempted with
docker build --progress=plain --target builder -t all-smi-builder-msrv-check ., but this environment cannot access/var/run/docker.sock, so the Docker-specific verification must be provided by GitHub Actions after merge.