Skip to content

668 lab 627 fix add tool issues#676

Merged
thetechnocrat-dev merged 7 commits intomainfrom
668-lab-627-add-tool-issues
Sep 28, 2023
Merged

668 lab 627 fix add tool issues#676
thetechnocrat-dev merged 7 commits intomainfrom
668-lab-627-add-tool-issues

Conversation

@thetechnocrat-dev
Copy link
Copy Markdown

@thetechnocrat-dev thetechnocrat-dev commented Sep 28, 2023

Changes

  • Changed Add Tool View to a JSON input form
  • Removed Tool JSON blob from Tool model
  • Added a unique Name field to Tool model
  • Add Tool view re-directs to Tool list view on success and displays error on failure
  • Added database migrations

https://www.loom.com/share/d69c59004605416b9f3d5154ac379391

@thetechnocrat-dev thetechnocrat-dev linked an issue Sep 28, 2023 that may be closed by this pull request
@linear
Copy link
Copy Markdown

linear bot commented Sep 28, 2023

LAB-627 add tool issues

Problems

  • The add tool view has hardcoded example data
  • The view also has [object object] fields
  • There is not enough padding around the submit button
  • The backend model stores everything as a JSON blob, which is unideal for indexing

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Sep 28, 2023 5:35pm

@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci September 28, 2023 12:51 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci September 28, 2023 12:56 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci September 28, 2023 15:42 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev changed the title 668 lab 627 add tool issues 668 lab 627 fix add tool issues Sep 28, 2023
@acashmoney acashmoney temporarily deployed to ci September 28, 2023 17:35 — with GitHub Actions Inactive
Copy link
Copy Markdown
Contributor

@acashmoney acashmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦉 ➡️ 🎯

@thetechnocrat-dev thetechnocrat-dev merged commit c35e3f0 into main Sep 28, 2023
@thetechnocrat-dev thetechnocrat-dev deleted the 668-lab-627-add-tool-issues branch September 28, 2023 18:32
alabdao pushed a commit that referenced this pull request Oct 11, 2023
Co-authored-by: Aakaash Meduri <aakaash.meduri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[LAB-627] add tool issues

2 participants