Conversation
When trying to compile the project I hit the following issue:
```
rbtree.c:1086:24: error: expression is not assignable
RHASH_IFNONE(hash) = IFNONE(self);
```
The problem is that this API is no longer public. It was made private in:
https://bugs.ruby-lang.org/issues/9889
With this change we no longer support smooth transition between RBTree and Hash,
which preserves default value. I'm not 100% sure that dropping support is the
right way but there's only much I can do. My Ruby C API knowledge is not very
deep.
This can potentially break someone's code but it doesn't seem to be too
critical.
BrianHawley
added a commit
to BrianHawley/rbtree3
that referenced
this pull request
Jan 19, 2020
Restores the functionality removed in kyrylo#3 in a way that's compatible with the newer Ruby versions.
BrianHawley
added a commit
to BrianHawley/rbtree3
that referenced
this pull request
Jan 20, 2020
Restores the functionality removed in kyrylo#3 in a way that's compatible with the newer Ruby versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to compile the project I hit the following issue:
The problem is that this API is no longer public. It was made private in:
https://bugs.ruby-lang.org/issues/9889
With this change we no longer support smooth transition between RBTree and Hash,
which preserves default value. I'm not 100% sure that dropping support is the
right way but there's only much I can do. My Ruby C API knowledge is not very
deep.
This can potentially break someone's code but it doesn't seem to be too
critical.