Skip to content

Mooncake PG#1387

Merged
UNIDY2002 merged 19 commits intomainfrom
mapc-ep
Jan 16, 2026
Merged

Mooncake PG#1387
UNIDY2002 merged 19 commits intomainfrom
mapc-ep

Conversation

@ympcMark
Copy link
Copy Markdown
Collaborator

@ympcMark ympcMark commented Jan 15, 2026 •
edited by UNIDY2002
Loading

Description

Part of #1225.

Split the Torch Distributed backend from Mooncake EP into a separate directory (Mooncake PG, i.e., process group)

Type of Change

  • Types
    • Bug fix
    • New feature
      • Transfer Engine
      • Mooncake Store
      • Mooncake EP
      • Integration
      • P2P Store
      • Python Wheel
    • Breaking change
    • CI/CD
    • Documentation update
    • Other

How Has This Been Tested?

# EP
python3 mooncake-wheel/tests/test_mooncake_ep.py
# PG
python3 mooncake-wheel/tests/test_mooncake_backend.py
python3 mooncake-wheel/tests/test_mooncake_backend_cpu.py

Checklist

  • I have performed a self-review of my own code.
  • I have formatted my own code using ./scripts/code_format.sh before submitting.
  • I have updated the documentation.
  • I have added tests to prove my changes are effective.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Jan 15, 2026

Summary of Changes

Hello @ympcMark, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the Mooncake project by extracting the Torch Distributed backend implementation into a new, dedicated mooncake-pg module. This separation enhances the overall modularity and organization of the codebase, making it more maintainable and easier to understand. The changes involve relocating key C++ source files, updating build configurations, and adjusting existing Python code to correctly import and utilize the newly structured process group functionalities.

Highlights

  • New Module Creation: A new mooncake-pg (Process Group) module has been introduced to house the Torch Distributed backend implementation.
  • Code Relocation and Refactoring: Core C++ source files and Python bindings related to the Torch Distributed backend have been moved from the mooncake-ep module to the new mooncake-pg module, improving modularity.
  • Build System and Import Updates: The build scripts (setup.py, build_wheel.sh) and existing Python code (mooncake_ep_buffer.py, test files) have been updated to correctly build and import functionalities from the new mooncake-pg module.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-code-quality[bot]
github-code-quality Bot found potential problems Jan 15, 2026
View reviewed changes
Comment thread mooncake-wheel/tests/test_mooncake_backend.py Fixed
Comment thread mooncake-wheel/tests/test_mooncake_backend_cpu.py Fixed
Comment thread mooncake-wheel/tests/test_mooncake_ep.py Fixed
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jan 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively refactors the codebase by splitting the Torch Distributed backend (Process Group) from the Mooncake EP into a new, dedicated mooncake-pg directory. This is a positive change for modularity and separation of concerns. The changes primarily involve moving files, updating build scripts, and adjusting imports. My review has identified a few minor areas for improvement, including code style consistency, a misleading error message, and an opportunity to reduce code duplication in the build script for better maintainability.

Comment thread .github/CODEOWNERS Outdated
Comment thread mooncake-integration/pg/pg_py.cpp Outdated
Comment thread mooncake-pg/setup.py Outdated
Comment thread mooncake-wheel/mooncake/pg.py Outdated
Comment thread scripts/build_wheel.sh
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 15, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

github-code-quality[bot]
github-code-quality Bot found potential problems Jan 16, 2026
View reviewed changes
Comment thread mooncake-wheel/tests/ep_test_utils.py Dismissed
@UNIDY2002 @gemini-code-assist
Update mooncake-wheel/mooncake/pg.py
6cbc91a 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
UNIDY2002
UNIDY2002 approved these changes Jan 16, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@UNIDY2002 UNIDY2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Now we can draw a clear line between the EP and PG modules.

github-code-quality[bot]
github-code-quality Bot found potential problems Jan 16, 2026
View reviewed changes
Comment thread mooncake-wheel/tests/test_mooncake_backend_perf.py Dismissed
@UNIDY2002 UNIDY2002 merged commit 971c99d into main Jan 16, 2026
17 of 19 checks passed
@UNIDY2002 UNIDY2002 deleted the mapc-ep branch January 22, 2026 03:08
XucSh pushed a commit to XucSh/Mooncake that referenced this pull request Jan 27, 2026
@ympcMark @XucSh
Split Mooncake PG out of Mooncake EP (kvcache-ai#1387)
f930695
JasonZhang517 pushed a commit to JasonZhang517/Mooncake that referenced this pull request Feb 9, 2026
@ympcMark
Split Mooncake PG out of Mooncake EP (kvcache-ai#1387)
568a870
@UNIDY2002 UNIDY2002 mentioned this pull request Mar 9, 2026
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UNIDY2002 UNIDY2002 UNIDY2002 approved these changes

@ShangmingCai ShangmingCai Awaiting requested review from ShangmingCai ShangmingCai is a code owner

@stmatengss stmatengss Awaiting requested review from stmatengss stmatengss is a code owner

@ykwd ykwd Awaiting requested review from ykwd ykwd is a code owner

@Ann-1024 Ann-1024 Awaiting requested review from Ann-1024 Ann-1024 is a code owner

+2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

run-ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ympcMark @codecov-commenter @UNIDY2002