Skip to content

Conversation

@dongjiang1989
Copy link
Member

What type of PR is this?

/kind feature

  • Unittest
  • Coverage 80%+
  • Build Success

What this PR does / why we need it:

  1. Add support orm cache: redis/memory

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.66% (target: -1.00%) 55.47%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6acd0f4) 6818 6139 90.04%
Head commit (3a2ae80) 6934 (+116) 6198 (+59) 89.39% (-0.66%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#29) 128 71 55.47%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@pull-request-size pull-request-size bot added the size/L size/L label Apr 16, 2024
@the-label-bot the-label-bot bot added the kind/feature kind/feature label Apr 16, 2024
@the-label-bot
Copy link

the-label-bot bot commented Apr 16, 2024

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind feature 0.997 ✔️
Size L 0.953 ✔️

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions github-actions bot requested a review from imlense April 16, 2024 12:14
Copy link
Member Author

@dongjiang1989 dongjiang1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongjiang1989 dongjiang1989 merged commit 929a39d into main Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature kind/feature size/L size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants