kernel: more agressively sanitize full kernel version#402
Conversation
|
/assign @ArangoGutierrez |
|
"agressively" is not a word you want to read on a Monday Morning 😀 |
|
/retest |
|
Prow is not happy :( |
|
+1 is it too late to add a short comment in the code mentioning that characters at the end of labels have different criteria than characters at the start or middle. It looks like it'll work; a comment just for future readability. |
Trim illegal characters from the beginning and end of the kernel version string. Label values must start and end with an alphanumeric and we want to have some 'version.full' label, even if a sanitized one.
5496654 to
ba4ecfe
Compare
Of course not. I added a short comment, do you think it's enough? |
+1. lgtm. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Shiva Krishna, Merla <smerla@nvidia.com>
Update NFD to v0.8.2 to fix: kubernetes-sigs/node-feature-discovery#402 See merge request nvidia/kubernetes/gpu-operator!239
Trim illegal characters from the beginning and end of the kernel version
string. Label values must start and end with an alphanumeric and we want
to have some 'version.full' label, even if a sanitized one.
Fixes #390