Skip to content

Improve metrics#1288

Merged
k8s-ci-robot merged 3 commits into
kubernetes-sigs:masterfrom
marquiz:devel/metrics
Jul 31, 2023
Merged

Improve metrics#1288
k8s-ci-robot merged 3 commits into
kubernetes-sigs:masterfrom
marquiz:devel/metrics

Conversation

@marquiz

@marquiz marquiz commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

Some changes to the initial metrics we added:

  • improve nfr processing time metric
    Change the metric from a simple gauge (that basically was a single value
    for the whole cluster) into a HistogramVec, aligning with the feature
    discovery duration metric in nfd-worker. This improved metric now has
    prometheus labels for the NFR name and node name, i.e. it is tracking
    per-NFR metric for each node being processed. Also, change the naming to
    better comply with prometheus suggested conventions.
  • improve the node updates gauge
    Rename the metric, better describe what we're measuring and better
    comply with prometheus naming conventions. Also change it to represent
    actual updates of the node object on the Kubernetes apiserver.
  • improve feature discovery duration metric
    Rename the "NodeName" prometheus label to "node", aligning with
    common prometheus/kubernetes conventions. Also reconfigure the
    prometheus histogram buckets (now 10ms to 1s) to better match the
    expected sample range.

@k8s-ci-robot k8s-ci-robot requested review from kad and zvonkok July 31, 2023 13:05
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@netlify

netlify Bot commented Jul 31, 2023

Copy link
Copy Markdown

Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 5091fef
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/64c7eb847a63f7000845106f
😎 Deploy Preview https://deploy-preview-1288--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marquiz

marquiz commented Jul 31, 2023

Copy link
Copy Markdown
Contributor Author

/assign @ArangoGutierrez

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 31, 2023

@ArangoGutierrez ArangoGutierrez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2023
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 1badcbdf156f59bcc0b880798a88ebe5a96a38d4

@marquiz

marquiz commented Jul 31, 2023

Copy link
Copy Markdown
Contributor Author

Some testing to do
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2023
marquiz added 3 commits July 31, 2023 19:45
Change the metric from a simple gauge (that basically was a single value
for the whole cluster) into a HistogramVec, aligning with the feature
discovery duration metric in nfd-worker. This improved metric now has
prometheus labels for the NFR name and node name, i.e. it is tracking
per-NFR metric for each node being processed. Also, change the naming to
better comply with prometheus suggested conventions.
Rename the metric, better describe what we're measuring and better
comply with prometheus naming conventions. Also change it to represent
actual updates of the node object on the Kubernetes apiserver.
Rename the "NodeName" prometheus label to  "node", aligning  with
common prometheus/kubernetes conventions. Also reconfigure the
prometheus histogram buckets (now 10ms to 1s) to better match the
expected sample range.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 31, 2023
@marquiz

marquiz commented Jul 31, 2023

Copy link
Copy Markdown
Contributor Author

Changed the "node updates" gauge to count actual updates of the node objects on the api server.

Also configured buckets for the NFR processing time and feature discovery time histograms. Only time and practice will tell how useful these 🙄
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2023

@ArangoGutierrez ArangoGutierrez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2023
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 7373b25a200d4c5a0478a1229274de776abe8bf8

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Jul 31, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1288 (5091fef) into master (e0f10a8) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 20.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1288      +/-   ##
==========================================
- Coverage   28.93%   28.93%   -0.01%     
==========================================
  Files          54       54              
  Lines        7316     7317       +1     
==========================================
  Hits         2117     2117              
- Misses       4971     4972       +1     
  Partials      228      228              
Files Changed Coverage Δ
pkg/nfd-master/metrics.go 0.00% <0.00%> (ø)
pkg/nfd-worker/metrics.go 0.00% <ø> (ø)
pkg/nfd-master/nfd-master.go 43.20% <33.33%> (-0.05%) ⬇️

... and 1 file with indirect coverage changes

@k8s-ci-robot k8s-ci-robot merged commit c1cb632 into kubernetes-sigs:master Jul 31, 2023
@marquiz marquiz mentioned this pull request Sep 6, 2023
25 tasks
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Sep 8, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [node-feature-discovery](https://github.com/kubernetes-sigs/node-feature-discovery) | minor | `0.13.4` -> `0.14.0` |

---

### Release Notes

<details>
<summary>kubernetes-sigs/node-feature-discovery (node-feature-discovery)</summary>

### [`v0.14.0`](https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.14.0)

[Compare Source](kubernetes-sigs/node-feature-discovery@v0.13.4...v0.14.0)

#### What's new

##### NodeFeature API

The [NodeFeature](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/usage/custom-resources.html#nodefeature) API is now enabled by default. The new CRD-based API replaces the previous gRPC-based communication between nfd-master and nfd-worker and, reducing network traffic and allows changes in NodeFeatureRules to take effect immediately (independent of the sleep-interval of nfd-worker). NodeFeature API can also be used to implement 3rd party extensions, see [customization guide](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/usage/customization-guide#nodefeature-custom-resource) for more details.

Garbage collection of stale NodeFeature objects was added in the form of nfd-gc daemon.

The gRPC API is now deprecated and will be removed in a future release. The related command-line flags are also deprecated (and don't have any effect when NodeFeature API is in use):

-   nfd-master: `-ca-file`, `-cert-file`, `-key-file`, `-port`, `-verify-node-name`
-   nfd-worker: `-ca-file`, `-cert-file`, `-key-file`, `-server`, `-server-name-override`

##### Metrics

NFD now provides Prometheus metrics for better observability. Also, the Helm and kustomize deployments support enabling metrics collection with the [Prometheus operator](https://github.com/prometheus-operator/prometheus-operator). See the [documentation](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/deployment/metrics.html) for more information about the available metrics and deployment instructions.

##### Hooks disabled by default

The deprecation of nfd-worker [hooks](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/usage/customization-guide.html#hooks) continues, disabling them by default in v0.14. Potential users of hooks are encouraged to switch to use the NFD CRDs ([NodeFeature](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/usage/customization-guide.html#nodefeature-custom-resource) and
[NodeFeatureRule](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/usage/customization-guide.html#nodefeaturerule-custom-resource)) or [feature files](https://kubernetes-sigs.github.io/node-feature-discovery/master/usage/customization-guide.html#feature-files). Hooks can still be enabled with the [`sources.local.hooksEnabled`](https://kubernetes-sigs.github.io/node-feature-discovery/master/reference/worker-configuration-reference.html#sourceslocalhooksenabled)
configuration option.

##### Feature files

**Expiry time:** NFD now supports specifying an expiry time for the features specified in a feature file, providing better lifecycle management for the feature labels. See the [documentation](https://kubernetes-sigs.github.io/node-feature-discovery/master/usage/customization-guide.html#input-format) for more details.

**Size limit:** There is now a 64kB size limit for feature files.

##### Miscellaneous

##### NodeFeatureRule API

Dynamic values for labels is now supported by using the `@` notation, see [documentation](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/usage/customization-guide.html#labels) for more details.

##### NFD-Master

-   support for leader election was added, enabling high-availability deployments with multiple-replicas of nfd-master (with the NodeFeature API enabled)
-   dynamically configurable logging parameters via the config file
-   configurable resync period for the CRD controller
-   parallelized node updates, speeding up simultaneous updates of large number of nodes (e.g. update in NodeFeatureRules in a big cluster), can be controlled with the [`-nfd-api-parallelism`](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/reference/master-commandline-reference.html#-nfd-api-parallelism) flag

##### CPU features

Detection of Intel TDX guests is now supported.

##### Logging

The project was migrated structured logging, making log messages more consistent, better machine parseable and enables future improvements in logging.

##### Support policy

The project now officially documented it's supported versions and deprecation policy, see the [documentation](https://kubernetes-sigs.github.io/node-feature-discovery/v0.14/reference/versions.html) for details.

#### List of PRs

-   test/e2e: use proper context ([#&#8203;1154](kubernetes-sigs/node-feature-discovery#1154))
-   deps: Update kubernetes to v1.27.1 ([#&#8203;1155](kubernetes-sigs/node-feature-discovery#1155))
-   generate: update k8s code-generator to v0.27.1 ([#&#8203;1156](kubernetes-sigs/node-feature-discovery#1156))
-   generate: update protoc to v22.3 ([#&#8203;1157](kubernetes-sigs/node-feature-discovery#1157))
-   generate: update controller-gen to v0.11.3 ([#&#8203;1158](kubernetes-sigs/node-feature-discovery#1158))
-   generate: update mockery to v2.25.1 ([#&#8203;1159](kubernetes-sigs/node-feature-discovery#1159))
-   nfd-master: support noPublish with -prune ([#&#8203;1161](kubernetes-sigs/node-feature-discovery#1161))
-   nfd-master: fix -prune ([#&#8203;1160](kubernetes-sigs/node-feature-discovery#1160))
-   nfd-master: don't create emtpy annotations ([#&#8203;1166](kubernetes-sigs/node-feature-discovery#1166))
-   nfd-master: fix a crash when processing NodeFeatureRules ([#&#8203;1173](kubernetes-sigs/node-feature-discovery#1173))
-   pkg/nfd-master/nfd-master.go: Fix typo ([#&#8203;1171](kubernetes-sigs/node-feature-discovery#1171))
-   nfd-master: reject malformed extended resource dynamic capacity assignment ([#&#8203;1169](kubernetes-sigs/node-feature-discovery#1169))
-   go.mod: update deps ([#&#8203;1178](kubernetes-sigs/node-feature-discovery#1178))
-   OWNERS: add ArangoGutierrez as an approver ([#&#8203;1180](kubernetes-sigs/node-feature-discovery#1180))
-   feat: add master resync period configurability ([#&#8203;1139](kubernetes-sigs/node-feature-discovery#1139))
-   nfd-topology-updater: fix wrong kubelet_internal_checkpoint path and compare basename to full path ([#&#8203;1167](kubernetes-sigs/node-feature-discovery#1167))
-   docs: add missing .md suffix to internal references ([#&#8203;1189](kubernetes-sigs/node-feature-discovery#1189))
-   nfd-master: log node name when processing NodeFeatureRules ([#&#8203;1191](kubernetes-sigs/node-feature-discovery#1191))
-   scripts/test-infra: provide PR info to codecov ([#&#8203;1194](kubernetes-sigs/node-feature-discovery#1194))
-   Match usage and example for prepare-release.sh ([#&#8203;1196](kubernetes-sigs/node-feature-discovery#1196))
-   apis/nfd: add unit tests for Feature type ([#&#8203;1190](kubernetes-sigs/node-feature-discovery#1190))
-   Update README to v0.13.1 ([#&#8203;1197](kubernetes-sigs/node-feature-discovery#1197))
-   scripts/test-infra: provide PR base SHA to codecov ([#&#8203;1199](kubernetes-sigs/node-feature-discovery#1199))
-   codecov: drop required minimum coverage ratio of a commit to 0% ([#&#8203;1200](kubernetes-sigs/node-feature-discovery#1200))
-   codecov: drop required minimum coverage ratio at patch level ([#&#8203;1201](kubernetes-sigs/node-feature-discovery#1201))
-   nfd-master: refactor api-controller object handling ([#&#8203;1198](kubernetes-sigs/node-feature-discovery#1198))
-   nfd-master: refactor filtering of labels, taints and ERs ([#&#8203;1202](kubernetes-sigs/node-feature-discovery#1202))
-   helm: fix mount for nfd-master config ([#&#8203;1204](kubernetes-sigs/node-feature-discovery#1204))
-   nfd-master: fix resync period config option ([#&#8203;1185](kubernetes-sigs/node-feature-discovery#1185))
-   deployment/helm: fix default for kubeletStateDir parameter ([#&#8203;1207](kubernetes-sigs/node-feature-discovery#1207))
-   deployment/kustomize: drop pod-resources mount for topology-updater ([#&#8203;1208](kubernetes-sigs/node-feature-discovery#1208))
-   test/e2e: refactor matching of node properties ([#&#8203;1184](kubernetes-sigs/node-feature-discovery#1184))
-   deployment/helm: avoid overlapping mount paths on topology-updater ([#&#8203;1212](kubernetes-sigs/node-feature-discovery#1212))
-   deployment/helm: user dedicated serviceaccount for topology-updater ([#&#8203;1213](kubernetes-sigs/node-feature-discovery#1213))
-   deployment/helm: improve handling of topologyUpdater.kubeletStateFiles ([#&#8203;1211](kubernetes-sigs/node-feature-discovery#1211))
-   topology-updater: use node IP in the default configz URI ([#&#8203;1218](kubernetes-sigs/node-feature-discovery#1218))
-   e2e: delete CRs only if found ([#&#8203;1221](kubernetes-sigs/node-feature-discovery#1221))
-   Add leader election for nfd-master ([#&#8203;1219](kubernetes-sigs/node-feature-discovery#1219))
-   Fixed typo in Header under deployment/kustomize.md ([#&#8203;1222](kubernetes-sigs/node-feature-discovery#1222))
-   nfd-master: use close for stop channel ([#&#8203;1227](kubernetes-sigs/node-feature-discovery#1227))
-   scripts/test-infra: bump golangci-lint to v1.52.2 ([#&#8203;1230](kubernetes-sigs/node-feature-discovery#1230))
-   nfd-master: add validation of label names and values ([#&#8203;1228](kubernetes-sigs/node-feature-discovery#1228))
-   Migrate to structured logging ([#&#8203;1223](kubernetes-sigs/node-feature-discovery#1223))
-   scripts/test-infra: add logcheck to verify script ([#&#8203;1235](kubernetes-sigs/node-feature-discovery#1235))
-   Update README to v0.13.2 ([#&#8203;1238](kubernetes-sigs/node-feature-discovery#1238))
-   github: update new-release issue template ([#&#8203;1239](kubernetes-sigs/node-feature-discovery#1239))
-   feat: support dynamic values for labels in the NodeFeatureRule ([#&#8203;1226](kubernetes-sigs/node-feature-discovery#1226))
-   feat: parallelize nodes update ([#&#8203;1133](kubernetes-sigs/node-feature-discovery#1133))
-   cpu: Discover TDX guests based on cpuid information ([#&#8203;1240](kubernetes-sigs/node-feature-discovery#1240))
-   deployment/kustomize: use a named port for nfd gRPC service ([#&#8203;1243](kubernetes-sigs/node-feature-discovery#1243))
-   Fix missing apostrophe for jq ([#&#8203;1245](kubernetes-sigs/node-feature-discovery#1245))
-   Fix a typo on nfd-master cmd ([#&#8203;1244](kubernetes-sigs/node-feature-discovery#1244))
-   Removal of the bases field as it is deprecated by kustomize ([#&#8203;1246](kubernetes-sigs/node-feature-discovery#1246))
-   Docs: Fix typo on customization-guide ([#&#8203;1247](kubernetes-sigs/node-feature-discovery#1247))
-   hooks: disable hooks by default from v0.14 ([#&#8203;1182](kubernetes-sigs/node-feature-discovery#1182))
-   Remove pkg's imported twice ([#&#8203;1248](kubernetes-sigs/node-feature-discovery#1248))
-   fix typo in helm chart ([#&#8203;1253](kubernetes-sigs/node-feature-discovery#1253))
-   Stop ticker in time to avoid memory leak ([#&#8203;1255](kubernetes-sigs/node-feature-discovery#1255))
-   nfd-master: check for nil references in nfdAPIUpdateAllNodes ([#&#8203;1258](kubernetes-sigs/node-feature-discovery#1258))
-   cpu: Take cgroupsv1 into account when reading misc.capacity ([#&#8203;1265](kubernetes-sigs/node-feature-discovery#1265))
-   go.mod: update kubernetes to v1.27.4 ([#&#8203;1268](kubernetes-sigs/node-feature-discovery#1268))
-   github: update assignees in new-release issue template ([#&#8203;1274](kubernetes-sigs/node-feature-discovery#1274))
-   Enable metrics via prometheus operator ([#&#8203;1242](kubernetes-sigs/node-feature-discovery#1242))
-   README: update to v0.13.3 ([#&#8203;1276](kubernetes-sigs/node-feature-discovery#1276))
-   docs: document version and deprecation policy ([#&#8203;1279](kubernetes-sigs/node-feature-discovery#1279))
-   docs: fix toc of topology-updater and topology-gc reference ([#&#8203;1278](kubernetes-sigs/node-feature-discovery#1278))
-   docs: remove useless TOCs ([#&#8203;1280](kubernetes-sigs/node-feature-discovery#1280))
-   Add optional labels to the podmonitor ([#&#8203;1282](kubernetes-sigs/node-feature-discovery#1282))
-   docs: describe supported Kubernetes versions ([#&#8203;1277](kubernetes-sigs/node-feature-discovery#1277))
-   docs: deprecation policy for Helm chart params ([#&#8203;1283](kubernetes-sigs/node-feature-discovery#1283))
-   Fix Topology Manager policy and scope not being updated after NRT creation ([#&#8203;1256](kubernetes-sigs/node-feature-discovery#1256))
-   generate: bump tools to their latest versions ([#&#8203;1284](kubernetes-sigs/node-feature-discovery#1284))
-   Improve metrics ([#&#8203;1288](kubernetes-sigs/node-feature-discovery#1288))
-   docs: align metrics documentation with latest changes on naming ([#&#8203;1289](kubernetes-sigs/node-feature-discovery#1289))
-   docs: unify formatting of NOTEs ([#&#8203;1292](kubernetes-sigs/node-feature-discovery#1292))
-   source/local: trim whitespace from input ([#&#8203;1293](kubernetes-sigs/node-feature-discovery#1293))
-   source/local: support comments in input ([#&#8203;1294](kubernetes-sigs/node-feature-discovery#1294))
-   nfd-master: use term node update instead of labeling ([#&#8203;1291](kubernetes-sigs/node-feature-discovery#1291))
-   docs: document -metrics flag in command line reference ([#&#8203;1296](kubernetes-sigs/node-feature-discovery#1296))
-   fix empty hugepages in some numa nodes caused no such file or directory errors ([#&#8203;1287](kubernetes-sigs/node-feature-discovery#1287))
-   scripts/test-infra: update logcheck tool to v0.6.0 ([#&#8203;1299](kubernetes-sigs/node-feature-discovery#1299))
-   scripts/test-infra: bump golangci-lint to v1.54.0 ([#&#8203;1300](kubernetes-sigs/node-feature-discovery#1300))
-   Update kubernetes to v1.28.0 ([#&#8203;1302](kubernetes-sigs/node-feature-discovery#1302))
-   docs: update github-pages gem to v228 ([#&#8203;1303](kubernetes-sigs/node-feature-discovery#1303))
-   topology-gc: fix Stop ([#&#8203;1306](kubernetes-sigs/node-feature-discovery#1306))
-   topology-gc: rename run() ([#&#8203;1309](kubernetes-sigs/node-feature-discovery#1309))
-   topology-gc: rename runGC to garbageCollect() ([#&#8203;1310](kubernetes-sigs/node-feature-discovery#1310))
-   nfd-topology-updater: add metrics support ([#&#8203;1295](kubernetes-sigs/node-feature-discovery#1295))
-   topology-gc: refactor unit tests ([#&#8203;1307](kubernetes-sigs/node-feature-discovery#1307))
-   topology-gc: move initial GC out of startNodeInformer() ([#&#8203;1308](kubernetes-sigs/node-feature-discovery#1308))
-   topology-gc: simplify listing of node objects ([#&#8203;1311](kubernetes-sigs/node-feature-discovery#1311))
-   metrics: additional metrics for nfd-master ([#&#8203;1290](kubernetes-sigs/node-feature-discovery#1290))
-   Garbage collection of NodeFeature objects ([#&#8203;1305](kubernetes-sigs/node-feature-discovery#1305))
-   topology-updater: make -version always runnable ([#&#8203;1297](kubernetes-sigs/node-feature-discovery#1297))
-   go.mod: update kubernetes to v1.28.1 ([#&#8203;1315](kubernetes-sigs/node-feature-discovery#1315))
-   Makefile: increase golangci-lint timeout to 10min ([#&#8203;1320](kubernetes-sigs/node-feature-discovery#1320))
-   docs: use ruby docker image for building docs ([#&#8203;1319](kubernetes-sigs/node-feature-discovery#1319))
-   README: update to v0.13.4 ([#&#8203;1324](kubernetes-sigs/node-feature-discovery#1324))
-   test: add node updater pool unit tests ([#&#8203;1252](kubernetes-sigs/node-feature-discovery#1252))
-   docs: nfd-updater: clarify accounting ([#&#8203;1321](kubernetes-sigs/node-feature-discovery#1321))
-   nfd-updater: events: enable timer-only flow ([#&#8203;1325](kubernetes-sigs/node-feature-discovery#1325))
-   docs: demote hooks in the customization guide ([#&#8203;1326](kubernetes-sigs/node-feature-discovery#1326))
-   Feat: add expiry date for feature files ([#&#8203;1285](kubernetes-sigs/node-feature-discovery#1285))
-   Dockerfile: bump grpc-health-probe to v0.4.19 ([#&#8203;1327](kubernetes-sigs/node-feature-discovery#1327))
-   e2e/test: make the nfd-gc test pass on one-node cluster ([#&#8203;1328](kubernetes-sigs/node-feature-discovery#1328))
-   Enable NodeFeature API by default ([#&#8203;1329](kubernetes-sigs/node-feature-discovery#1329))
-   tls.md: Add note ([#&#8203;1332](kubernetes-sigs/node-feature-discovery#1332))
-   nfd_gc_test.go: fix multiple import of same pkg ([#&#8203;1333](kubernetes-sigs/node-feature-discovery#1333))
-   feat: add feature file size limit ([#&#8203;1335](kubernetes-sigs/node-feature-discovery#1335))
-   sources/custom: convert static rules to new format ([#&#8203;1336](kubernetes-sigs/node-feature-discovery#1336))
-   nfd-master: add config file options for logging ([#&#8203;1338](kubernetes-sigs/node-feature-discovery#1338))
-   Deprecate gRPC API ([#&#8203;1334](kubernetes-sigs/node-feature-discovery#1334))
-   Helm: conditionally add annotations if defined ([#&#8203;1331](kubernetes-sigs/node-feature-discovery#1331))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yMy4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/78
Co-authored-by: Renovate <renovate@ptinem.io>
Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants