Skip to content

update dependencies#24

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
pohly:dependency-update
Aug 8, 2023
Merged

update dependencies#24
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
pohly:dependency-update

Conversation

@pohly

@pohly pohly commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

This fixes random parser failures.

Fixes: #23

@pohly
update dependencies
bb72225 
This fixes random parser failures.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 8, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2023
@k8s-ci-robot

k8s-ci-robot commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If logtools contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 8, 2023
@pohly

pohly commented Aug 8, 2023

Copy link
Copy Markdown
Contributor Author

/cc @marquiz

@k8s-ci-robot k8s-ci-robot requested a review from marquiz August 8, 2023 14:13
marquiz
marquiz approved these changes Aug 8, 2023
View reviewed changes

@marquiz marquiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pohly! Verified that this fixes the flakiness I had
/lgtm

@k8s-ci-robot

k8s-ci-robot commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4729ca2 into kubernetes-sigs:main Aug 8, 2023
@marquiz marquiz mentioned this pull request Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@logicalhan logicalhan Awaiting requested review from logicalhan

@thockin thockin Awaiting requested review from thockin

1 more reviewer

@marquiz marquiz marquiz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marquiz marquiz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky results for logcheck

3 participants

@pohly @k8s-ci-robot @marquiz