Skip to content

add lws editer and viewer roles to kustomize and helm #8513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Jan 10, 2026
Merged

add lws editer and viewer roles to kustomize and helm #8513

k8s-ci-robot merged 1 commit into from
Jan 10, 2026

Conversation

@kannon92
Copy link
Contributor

@kannon92 kannon92 commented Jan 9, 2026

What type of PR is this?

/kind bug

What this PR does / why we need it:

Add LWS RBAC roles for editor/viewer roles

Which issue(s) this PR fixes:

Fixes #8506

Special notes for your reviewer:

Does this PR introduce a user-facing change?

add lws editer and viewer roles to kustomize and helm

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jan 9, 2026
@netlify
Copy link

netlify bot commented Jan 9, 2026 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit e2fbd9f
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/69616a8eab9f7c0008f0dc1f
😎 Deploy Preview https://deploy-preview-8513--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 9, 2026
@kannon92 kannon92 mentioned this pull request Jan 9, 2026
Closed
@kannon92
Copy link
Contributor Author

kannon92 commented Jan 9, 2026

cc @Huang-Wei @tenzen-y

Huang-Wei
Huang-Wei reviewed Jan 9, 2026
View reviewed changes
Copy link
Contributor

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 9, 2026

LGTM label has been added.

DetailsGit tree hash: 2d73fe219b264f227a46d93ba2944fea820c3f8b

tenzen-y
tenzen-y reviewed Jan 10, 2026
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 10, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2026
@tenzen-y
Copy link
Member

tenzen-y commented Jan 10, 2026

/cherry-pick release-0.14
/cherry-pick release-0.15

@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Jan 10, 2026

@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.14, release-0.15 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick release-0.14
/cherry-pick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 4a4b0a0 into kubernetes-sigs:main Jan 10, 2026
30 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.16 milestone Jan 10, 2026
@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Jan 10, 2026

@tenzen-y: new pull request created: #8514

Details

In response to this:

/cherry-pick release-0.14
/cherry-pick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 10, 2026
Closed
@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Jan 10, 2026

@tenzen-y: new pull request created: #8515

Details

In response to this:

/cherry-pick release-0.14
/cherry-pick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 10, 2026
Merged
@tenzen-y
Copy link
Member

tenzen-y commented Jan 12, 2026

/cherry-pick release-0.14

@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Jan 12, 2026

@tenzen-y: new pull request created: #8544

Details

In response to this:

/cherry-pick release-0.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 12, 2026
Closed
@kannon92 kannon92 mentioned this pull request Jan 12, 2026
Merged
k8s-ci-robot pushed a commit that referenced this pull request Jan 13, 2026
@kannon92
Automated cherry pick of #8513: add lws editer and viewer roles to ku…
d1d7720 
…stomize and helm (#8554)

* add lws editer and viewer roles to kustomize and helm

* remove license template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

@mimowo mimowo Awaiting requested review from mimowo

+1 more reviewer

@Huang-Wei Huang-Wei Huang-Wei left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Huang-Wei Huang-Wei

@tenzen-y tenzen-y

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v0.16

Development

Successfully merging this pull request may close these issues.

LWS RBACs are missing

5 participants

@kannon92 @k8s-ci-robot @tenzen-y @k8s-infra-cherrypick-robot @Huang-Wei