Skip to content

🐛 ci: fix golangci-lint installation#682

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
ahmetb:fix-test
May 25, 2022
Merged

🐛 ci: fix golangci-lint installation#682
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
ahmetb:fix-test

Conversation

@ahmetb

@ahmetb ahmetb commented May 25, 2022

Copy link
Copy Markdown
Member

install.goreleaser.com is now deprecated and stopped working so the tests
in new PRs are failing. Instructions are from https://golangci-lint.run/usage/install/#other-ci.

`install.goreleaser.com` is now deprecated and stopped working so the tests
in new PRs are failing.
@ahmetb ahmetb changed the title ci: fix golangci-lint installation :bug: ci: fix golangci-lint installation May 25, 2022
@ahmetb ahmetb changed the title :bug: ci: fix golangci-lint installation 🐛 ci: fix golangci-lint installation May 25, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 25, 2022
@k8s-triage-robot

Copy link
Copy Markdown

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 25, 2022

@alvaroaleman alvaroaleman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2022
@alvaroaleman

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit f89071a into kubernetes-sigs:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants