Skip to content

Resolve reference in order to remove $ref which is not supported by k8s#412

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
zlabjp:resolve-ref
Mar 10, 2020
Merged

Resolve reference in order to remove $ref which is not supported by k8s#412
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
zlabjp:resolve-ref

Conversation

@tatsuhiro-t
Copy link
Copy Markdown

@tatsuhiro-t tatsuhiro-t commented Mar 5, 2020

Fixes #324

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 5, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 5, 2020

Welcome @tatsuhiro-t!

It looks like this is your first PR to kubernetes-sigs/controller-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 5, 2020
@k8s-ci-robot k8s-ci-robot requested a review from droot March 5, 2020 09:12
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 5, 2020
@tatsuhiro-t
Copy link
Copy Markdown
Author

tatsuhiro-t commented Mar 5, 2020

/assign @mengqiy

@mengqiy
Copy link
Copy Markdown
Member

mengqiy commented Mar 10, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mengqiy, tatsuhiro-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 075d9a8 into kubernetes-sigs:master Mar 10, 2020
DirectXMan12
DirectXMan12 reviewed Mar 10, 2020
View reviewed changes
Comment thread pkg/crd/flatten.go
return nil, fmt.Errorf("unable to locate schema for type %s", typ)
}
return &baseSchema, nil
return f.FlattenSchema(baseSchema, typ.Package), nil
Copy link
Copy Markdown
Contributor

@DirectXMan12 DirectXMan12 Mar 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is absolutely not the right way to fix this

Copy link
Copy Markdown
Contributor

@DirectXMan12 DirectXMan12 Mar 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given the contract of this method

@vincepri vincepri mentioned this pull request Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@droot droot Awaiting requested review from droot

1 more reviewer

@DirectXMan12 DirectXMan12 DirectXMan12 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mengqiy mengqiy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

controller-tools creates schema with '$ref' which is not supported in k8s

4 participants

@tatsuhiro-t @k8s-ci-robot @mengqiy @DirectXMan12