🐛markers/OneOf: make order deterministic relative to XValidation#1224
🐛markers/OneOf: make order deterministic relative to XValidation#1224k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
Conversation
Currently, if both XValidation and AtMostOneOf/ExactlyOneOf constraints are specified, the ordering of CEL rules can change due to both sets of markers have the same apply priority. This change ensures that OneOf markers always run **after** XValidation markers.
|
Hi @shashankram. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign @JoelSpeed @alvaroaleman |
|
This makes sense, but I wonder, if we ever changed the XValidation priority, would we pick up on this? Is there a way to make sure in the future that the prio of this marker is always after the XValidation? /ok-to-test |
@JoelSpeed fixed it to make it more explicit |
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: cb3589b5ca676e18a5875404a3884128907e2533 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, shashankram The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🐛markers/OneOf: make order deterministic relative to XValidation
Currently, if both XValidation and AtMostOneOf/ExactlyOneOf constraints are specified, the ordering of CEL rules can change due to both sets of markers have the same apply priority. This change ensures that OneOf markers always run after XValidation markers. Without this, the generated CRD can change without any API changes, which is undesirable.